Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 1835933002: [mojo-edk] Trim read buffer to keep its size down (Closed)

Created:
4 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Trim read buffer to keep its size down Shrinks Channel's read buffer back down to the maximum unused capacity any time its contents have been fully discarded. This prevents us from permanently wasting memory after a large IPC is transmitted. Based on work detailed in issue 529940, the max unused capacity has also been reduced from 256 kB down to 64 kB. In practice we rarely transmit messages larger than this, so the performance impact of these extra allocations should be negligible. BUG=593731, 500019 R=amistry@chromium.org Committed: https://crrev.com/3e0d30405b64ff0011aa347e9ecbe891e9e2ec66 Cr-Commit-Position: refs/heads/master@{#383862}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M mojo/edk/system/channel.cc View 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ken Rockot(use gerrit already)
4 years, 8 months ago (2016-03-28 17:06:43 UTC) #1
Anand Mistry (off Chromium)
lgtm
4 years, 8 months ago (2016-03-29 22:02:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1835933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1835933002/20001
4 years, 8 months ago (2016-03-29 22:03:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 8 months ago (2016-03-29 23:34:10 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 23:35:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e0d30405b64ff0011aa347e9ecbe891e9e2ec66
Cr-Commit-Position: refs/heads/master@{#383862}

Powered by Google App Engine
This is Rietveld 408576698