Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1835873002: Removes BatteryDispatcherProxy. (Closed)

Created:
4 years, 8 months ago by Yuki
Modified:
4 years, 8 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, mlamouri+watch-blink_chromium.org, kinuko+watch, timvolodine, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes BatteryDispatcherProxy. It's now okay to use device/battery/battery_monitor.mojom directly from modules/. Let's remove unnecessary BatteryDispatcherProxy. BatteryDispatcherProxyTest will be removed, because it's already been covered with layout tests. BUG=561879 Committed: https://crrev.com/4b61fe784fe7c6bf1db5461cd5a7f31bccba0922 Cr-Commit-Position: refs/heads/master@{#383700}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Fixes export settings. #

Patch Set 5 : Synced. #

Patch Set 6 : Fixes export settings again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -298 lines) Patch
M third_party/WebKit/Source/modules/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/battery/BatteryDispatcher.h View 4 5 1 chunk +13 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/battery/BatteryDispatcher.cpp View 3 chunks +30 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/battery/BatteryManager.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/battery/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/battery/battery_status.h View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/battery/testing/InternalsBattery.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/modules.gyp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 2 chunks +1 line, -6 lines 0 comments Download
D third_party/WebKit/Source/platform/battery/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/platform/battery/battery_dispatcher_proxy.h View 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/WebKit/Source/platform/battery/battery_dispatcher_proxy.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/WebKit/Source/platform/battery/battery_dispatcher_proxy_unittest.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D third_party/WebKit/Source/platform/battery/battery_status.h View 1 chunk +0 lines, -60 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 2 3 4 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform_tests.gyp View 2 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Yuki
Could you review this CL?
4 years, 8 months ago (2016-03-29 06:03:12 UTC) #3
haraken
LGTM
4 years, 8 months ago (2016-03-29 06:07:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1835873002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1835873002/100001
4 years, 8 months ago (2016-03-29 08:35:16 UTC) #7
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 8 months ago (2016-03-29 10:44:52 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 10:46:36 UTC) #11
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/4b61fe784fe7c6bf1db5461cd5a7f31bccba0922
Cr-Commit-Position: refs/heads/master@{#383700}

Powered by Google App Engine
This is Rietveld 408576698