Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1475)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 1835843002: WIP: Fix foreignObject cullrect Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@gmail.com> 9 * Christian Biesinger <cbiesinger@gmail.com>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 1078 matching lines...) Expand 10 before | Expand all | Expand 10 after
1089 { 1089 {
1090 if (!m_scrollCorner && !hasScrollbar()) 1090 if (!m_scrollCorner && !hasScrollbar())
1091 return; 1091 return;
1092 if (!m_scrollCorner && hasOverlayScrollbars()) 1092 if (!m_scrollCorner && hasOverlayScrollbars())
1093 return; 1093 return;
1094 1094
1095 const LayoutObject& actualLayoutObject = layoutObjectForScrollbar(box()); 1095 const LayoutObject& actualLayoutObject = layoutObjectForScrollbar(box());
1096 RefPtr<ComputedStyle> corner = box().hasOverflowClip() ? actualLayoutObject. getUncachedPseudoStyle(PseudoStyleRequest(PseudoIdScrollbarCorner), actualLayout Object.style()) : PassRefPtr<ComputedStyle>(nullptr); 1096 RefPtr<ComputedStyle> corner = box().hasOverflowClip() ? actualLayoutObject. getUncachedPseudoStyle(PseudoStyleRequest(PseudoIdScrollbarCorner), actualLayout Object.style()) : PassRefPtr<ComputedStyle>(nullptr);
1097 if (corner) { 1097 if (corner) {
1098 if (!m_scrollCorner) { 1098 if (!m_scrollCorner) {
1099 m_scrollCorner = LayoutScrollbarPart::createAnonymous(&box().documen t()); 1099 m_scrollCorner = LayoutScrollbarPart::createAnonymous(&box().documen t(), this);
1100 m_scrollCorner->setDangerousOneWayParent(&box()); 1100 m_scrollCorner->setDangerousOneWayParent(&box());
1101 } 1101 }
1102 m_scrollCorner->setStyleWithWritingModeOfParent(corner.release()); 1102 m_scrollCorner->setStyleWithWritingModeOfParent(corner.release());
1103 } else if (m_scrollCorner) { 1103 } else if (m_scrollCorner) {
1104 m_scrollCorner->destroy(); 1104 m_scrollCorner->destroy();
1105 m_scrollCorner = nullptr; 1105 m_scrollCorner = nullptr;
1106 } 1106 }
1107 } 1107 }
1108 1108
1109 bool PaintLayerScrollableArea::hitTestOverflowControls(HitTestResult& result, co nst IntPoint& localPoint) 1109 bool PaintLayerScrollableArea::hitTestOverflowControls(HitTestResult& result, co nst IntPoint& localPoint)
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
1217 1217
1218 void PaintLayerScrollableArea::updateResizerStyle() 1218 void PaintLayerScrollableArea::updateResizerStyle()
1219 { 1219 {
1220 if (!m_resizer && !box().canResize()) 1220 if (!m_resizer && !box().canResize())
1221 return; 1221 return;
1222 1222
1223 const LayoutObject& actualLayoutObject = layoutObjectForScrollbar(box()); 1223 const LayoutObject& actualLayoutObject = layoutObjectForScrollbar(box());
1224 RefPtr<ComputedStyle> resizer = box().hasOverflowClip() ? actualLayoutObject .getUncachedPseudoStyle(PseudoStyleRequest(PseudoIdResizer), actualLayoutObject. style()) : PassRefPtr<ComputedStyle>(nullptr); 1224 RefPtr<ComputedStyle> resizer = box().hasOverflowClip() ? actualLayoutObject .getUncachedPseudoStyle(PseudoStyleRequest(PseudoIdResizer), actualLayoutObject. style()) : PassRefPtr<ComputedStyle>(nullptr);
1225 if (resizer) { 1225 if (resizer) {
1226 if (!m_resizer) { 1226 if (!m_resizer) {
1227 m_resizer = LayoutScrollbarPart::createAnonymous(&box().document()); 1227 m_resizer = LayoutScrollbarPart::createAnonymous(&box().document(), this);
1228 m_resizer->setDangerousOneWayParent(&box()); 1228 m_resizer->setDangerousOneWayParent(&box());
1229 } 1229 }
1230 m_resizer->setStyleWithWritingModeOfParent(resizer.release()); 1230 m_resizer->setStyleWithWritingModeOfParent(resizer.release());
1231 } else if (m_resizer) { 1231 } else if (m_resizer) {
1232 m_resizer->destroy(); 1232 m_resizer->destroy();
1233 m_resizer = nullptr; 1233 m_resizer = nullptr;
1234 } 1234 }
1235 } 1235 }
1236 1236
1237 IntSize PaintLayerScrollableArea::offsetFromResizeCorner(const IntPoint& absolut ePoint) const 1237 IntSize PaintLayerScrollableArea::offsetFromResizeCorner(const IntPoint& absolut ePoint) const
(...skipping 347 matching lines...) Expand 10 before | Expand all | Expand 10 after
1585 } 1585 }
1586 1586
1587 DEFINE_TRACE(PaintLayerScrollableArea::ScrollbarManager) 1587 DEFINE_TRACE(PaintLayerScrollableArea::ScrollbarManager)
1588 { 1588 {
1589 visitor->trace(m_scrollableArea); 1589 visitor->trace(m_scrollableArea);
1590 visitor->trace(m_hBar); 1590 visitor->trace(m_hBar);
1591 visitor->trace(m_vBar); 1591 visitor->trace(m_vBar);
1592 } 1592 }
1593 1593
1594 } // namespace blink 1594 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698