Issue 183583003: Rebaseline fast/js/JSON-stringify.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183583003: Rebaseline fast/js/JSON-stringify.html (Closed)

Created:
6 years, 9 months ago by cbiesinger

Modified:
6 years, 9 months ago

Reviewers:
Yang

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Rebaseline fast/js/JSON-stringify.html This changes some FAIL to PASS lines, likely cause was the V8 roll in https://codereview.chromium.org/184163003, specifically https://github.com/v8/v8/commit/1e02b1d60095b06ac2f7ef372ca2af6028609119 CC=jkummerow@chromium.org,verwaest@chromium.org TBR=yangguo@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168404

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	LayoutTests/platform/win/fast/js/JSON-stringify-expected.txt	View		2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

cbiesinger

Committed patchset #1 manually as r168404 (presubmit successful).

6 years, 9 months ago (2014-03-04 19:48:10 UTC) #1

Yang

6 years, 9 months ago (2014-03-05 07:40:55 UTC) #2

Message was sent while issue was closed.

On 2014/03/04 19:48:10, cbiesinger wrote:
> Committed patchset #1 manually as r168404 (presubmit successful).

LGTM. FYI I expect more FAILs to turn into PASS after this fix has landed and
rolled:
https://codereview.chromium.org/187053003/

Expand Messages | Collapse Messages