Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 183583002: Use the invalidation tree walk for all class mutations, not just those that support (Closed)

Created:
6 years, 9 months ago by chrishtr
Modified:
6 years, 9 months ago
Reviewers:
esprehn, ojan
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, rune
Visibility:
Public.

Description

Use the invalidation tree walk for all class mutations, not just those that support targeted style recalc. This simplifies the code a bit and unifies the code paths. BUG=335247 R=esprehn@chromium.org, ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168175

Patch Set 1 #

Patch Set 2 : Fix. #

Patch Set 3 : Fix. #

Patch Set 4 : Fixl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -57 lines) Patch
M Source/core/css/RuleFeature.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 2 3 5 chunks +18 lines, -52 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
chrishtr
As a data point, when I first wrote this CL a few days ago, it ...
6 years, 9 months ago (2014-02-27 18:37:28 UTC) #1
esprehn
lgtm, I agree it's good to have a single path for this system
6 years, 9 months ago (2014-02-27 19:07:53 UTC) #2
ojan
You can also delete classInvalidationRequiresSubtreeRecalc now, no?
6 years, 9 months ago (2014-02-27 20:21:25 UTC) #3
chrishtr
@ojan: yes you are right. Removed.
6 years, 9 months ago (2014-02-27 22:43:10 UTC) #4
ojan
lgtm
6 years, 9 months ago (2014-02-28 01:34:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/183583002/20001
6 years, 9 months ago (2014-02-28 01:34:39 UTC) #6
chrishtr
The CQ bit was unchecked by chrishtr@chromium.org
6 years, 9 months ago (2014-02-28 01:36:22 UTC) #7
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 9 months ago (2014-02-28 18:10:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/183583002/40001
6 years, 9 months ago (2014-02-28 18:10:40 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-28 20:33:03 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=20552
6 years, 9 months ago (2014-02-28 20:33:03 UTC) #11
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 9 months ago (2014-02-28 22:05:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/183583002/60001
6 years, 9 months ago (2014-02-28 22:05:31 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-28 23:23:25 UTC) #14
commit-bot: I haz the power
Retried try job too often on blink_android_compile_dbg for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_android_compile_dbg&number=1064
6 years, 9 months ago (2014-02-28 23:23:25 UTC) #15
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 9 months ago (2014-02-28 23:41:31 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/183583002/60001
6 years, 9 months ago (2014-02-28 23:41:52 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-01 00:52:36 UTC) #18
commit-bot: I haz the power
Retried try job too often on blink_android_compile_dbg for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_android_compile_dbg&number=1093
6 years, 9 months ago (2014-03-01 00:52:36 UTC) #19
chrishtr
6 years, 9 months ago (2014-03-01 00:57:10 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 manually as r168175 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698