Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: components/network_time/network_time_tracker.h

Issue 1835823002: network_time_tracker: add temporary time protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add test of signed bad data Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/network_time/network_time_tracker.h
diff --git a/components/network_time/network_time_tracker.h b/components/network_time/network_time_tracker.h
index 7f2eb8792031d2cf56c13c17dda1b49909a0e000..b0a9ba348fdc7fc8f125db00d419d5f079188ab1 100644
--- a/components/network_time/network_time_tracker.h
+++ b/components/network_time/network_time_tracker.h
@@ -7,17 +7,31 @@
#include <memory>
+#include "base/gtest_prod_util.h"
#include "base/macros.h"
+#include "base/memory/ref_counted.h"
#include "base/threading/thread_checker.h"
#include "base/time/clock.h"
#include "base/time/time.h"
+#include "base/timer/timer.h"
+#include "net/url_request/url_fetcher_delegate.h"
+#include "url/gurl.h"
class PrefRegistrySimple;
class PrefService;
namespace base {
class TickClock;
-}
+} // namespace base
+
+namespace client_update_protocol {
+class Ecdsa;
+} // namespace client_udpate_protocol
+
+namespace net {
+class URLFetcher;
+class URLRequestContextGetter;
+} // namespace net
namespace network_time {
@@ -30,14 +44,18 @@ const int64_t kTicksResolutionMs = 1; // Assume 1ms for non-windows platforms.
// A class that receives network time updates and can provide the network time
// for a corresponding local time. This class is not thread safe.
-class NetworkTimeTracker {
+class NetworkTimeTracker : public net::URLFetcherDelegate {
public:
static void RegisterPrefs(PrefRegistrySimple* registry);
+ // Constructor. Arguments may be stubbed out for tests. |getter|, if not
+ // null, will cause automatic queries to a time server. Otherwise, time is
+ // available only if |UpdateNetworkTime| is called.
NetworkTimeTracker(std::unique_ptr<base::Clock> clock,
std::unique_ptr<base::TickClock> tick_clock,
- PrefService* pref_service);
- ~NetworkTimeTracker();
+ PrefService* pref_service,
+ scoped_refptr<net::URLRequestContextGetter> getter);
+ ~NetworkTimeTracker() override;
// Sets |network_time| to an estimate of the true time. Returns true if time
// is available, and false otherwise. If |uncertainty| is non-NULL, it will
@@ -61,7 +79,43 @@ class NetworkTimeTracker {
base::TimeDelta latency,
base::TimeTicks post_time);
+ void SetMaxResponseSizeForTesting(size_t limit);
+
+ void SetPublicKeyForTesting(base::StringPiece);
mmenke 2016/05/06 15:00:37 Looks to me like StringPieces are generally passed
mmenke 2016/05/06 15:00:37 nit: +key (argument name).
mab 2016/05/06 18:12:37 Done.
mab 2016/05/06 18:12:37 Done.
+
+ void SetTimeServerURLForTesting(const GURL& url);
+
+ bool QueryTimeServiceForTesting();
+
+ void WaitForFetchForTesting(uint32_t nonce);
mmenke 2016/05/06 15:00:37 include stdint.h
mab 2016/05/06 18:12:37 Done.
+
+ base::TimeDelta GetTimerDelayForTesting() const;
+
private:
+ // If synchronization has been lost, sends a query to the secure time service.
+ // Upon response, execution resumes in |OnURLFetchComplete|.
+ void QueryTimeService();
+
+ // Updates network time from a time server response, returning true
+ // if successful.
+ bool UpdateTimeFromResponse();
+
+ // net::URLFetcherDelegate:
+ // Called to process responses from the secure time service.
+ void OnURLFetchComplete(const net::URLFetcher* source) override;
+
+ // Sets the next time query to be run at the specified time.
+ void QueueTimeQuery(base::TimeDelta delay);
+
+ // State variables for internally-managed secure time service queries.
+ GURL server_url_;
+ size_t max_response_size_;
+ base::RepeatingTimer query_timer_;
+ scoped_refptr<net::URLRequestContextGetter> getter_;
+ std::unique_ptr<net::URLFetcher> time_fetcher_;
+ base::TimeTicks fetch_started_;
+ std::unique_ptr<client_update_protocol::Ecdsa> query_signer_;
+
// The |Clock| and |TickClock| are used to sanity-check one another, allowing
// the NetworkTimeTracker to notice e.g. suspend/resume events and clock
// resets.

Powered by Google App Engine
This is Rietveld 408576698