Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Unified Diff: components/network_time/network_time_tracker.h

Issue 1835823002: network_time_tracker: add temporary time protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: estark review 1 Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/network_time/network_time_tracker.h
diff --git a/components/network_time/network_time_tracker.h b/components/network_time/network_time_tracker.h
index dc7524a58302b2748c33941bc40938a73f792392..4db0bc67455f49ca688ee4f3939829009dba3139 100644
--- a/components/network_time/network_time_tracker.h
+++ b/components/network_time/network_time_tracker.h
@@ -5,11 +5,14 @@
#ifndef COMPONENTS_NETWORK_TIME_NETWORK_TIME_TRACKER_H_
#define COMPONENTS_NETWORK_TIME_NETWORK_TIME_TRACKER_H_
+#include "base/gtest_prod_util.h"
#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
#include "base/threading/thread_checker.h"
#include "base/time/clock.h"
#include "base/time/time.h"
+#include "base/timer/timer.h"
+#include "net/url_request/url_fetcher_delegate.h"
class PrefRegistrySimple;
class PrefService;
@@ -18,6 +21,15 @@ namespace base {
class TickClock;
}
+namespace client_update_protocol {
+class Ecdsa;
+}
+
+namespace net {
+class URLFetcher;
+class URLRequestContextGetter;
+}
estark 2016/03/28 23:18:59 nit: these should all end with } // namespace n
mab 2016/03/29 03:13:03 Done.
+
namespace network_time {
// Clock resolution is platform dependent.
@@ -29,14 +41,18 @@ const int64_t kTicksResolutionMs = 1; // Assume 1ms for non-windows platforms.
// A class that receives network time updates and can provide the network time
// for a corresponding local time. This class is not thread safe.
-class NetworkTimeTracker {
+class NetworkTimeTracker : public net::URLFetcherDelegate {
public:
static void RegisterPrefs(PrefRegistrySimple* registry);
+ // Constructor. Arguments may be stubbed out for tests. |getter|, if not
+ // null, will cause automatic queries to a time server. Otherwise, time is
+ // available only if |UpdateNetworkTime| is called.
NetworkTimeTracker(scoped_ptr<base::Clock> clock,
scoped_ptr<base::TickClock> tick_clock,
- PrefService* pref_service);
- ~NetworkTimeTracker();
+ PrefService* pref_service,
+ net::URLRequestContextGetter* getter = nullptr);
+ ~NetworkTimeTracker() override;
// Sets |network_time| to an estimate of the true time. Returns true if time
// is available, and false otherwise. If |uncertainty| is non-NULL, it will
@@ -61,6 +77,26 @@ class NetworkTimeTracker {
base::TimeTicks post_time);
private:
+ FRIEND_TEST_ALL_PREFIXES(NetworkTimeTrackerTest, UpdateFromNetwork);
+ FRIEND_TEST_ALL_PREFIXES(NetworkTimeTrackerTest, NoNetworkQueryWhileSynced);
+ FRIEND_TEST_ALL_PREFIXES(NetworkTimeTrackerTest,
+ UpdateFromNetworkBadSignature);
+
+ // Sends a query to the secure time service. Upon response, execution resumes
+ // in |OnURLFetchComplete|.
+ void QueryTimeService();
+
+ // net::URLFetcherDelegate:
+ // Called to process responses from the secure time service.
+ void OnURLFetchComplete(const net::URLFetcher* source) override;
+
+ // State variables for internally-managed secure time service queries.
+ base::RepeatingTimer query_timer_;
+ net::URLRequestContextGetter* getter_;
+ scoped_ptr<net::URLFetcher> time_fetcher_;
+ base::TimeTicks fetch_started_;
+ scoped_ptr<client_update_protocol::Ecdsa> query_signer_;
+
// The |Clock| and |TickClock| are used to sanity-check one another, allowing
// the NetworkTimeTracker to notice e.g. suspend/resume events and clock
// resets.

Powered by Google App Engine
This is Rietveld 408576698