Adds modules_unittest to ndk-apk script.

build/android/pylib/gtest/test_runner.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import glob
 import logging
 import os
 
 from pylib import android_commands
 from pylib import constants
@@ skipping 172 matching lines @@
         'content/test/data/nosniff-test.html.mock-http-headers',
         'content/test/data/accessibility',
         'content/test/data/dynamic1.html',
         'content/test/data/browser_plugin_focus_child.html',
         'content/test/data/rwhv_compositing_animation.html',
         'content/test/data/click-noreferrer-links.html',
         'content/test/data/browser_plugin_focus.html',
         'content/test/data/media',
         'third_party/webgl_conformance',
     ]
+  elif test_suite_basename == 'modules_unittests':

[frankf, 2013/07/01 18:14:47]

We're moving to using isolate files instead of hardcoding deps here. Are these
tests run on other platforms?

[frankf, 2013/07/01 18:32:38]

So the goal is to run these tests on Android buildbots on chromium waterfall
right? If so, it makes sense to create an isolate file for it (See
https://codereview.chromium.org/17267004/).

On 2013/07/01 18:14:47, frankf wrote:

[hellner1, 2013/07/02 14:49:25]

.isolate-file in http://webrtc-codereview.appspot.com/1750004/.

Regarding being in the waterfall: we want to run it for every cl submitted to
WebRTC but we don't want it to flag a break in Chrome. We make cuts from WebRTC
to Chromium on a weekly basis. I.e. the tests we want to run are on a modified
Chromium workspace where we replace the WebRTC cut (= stable) with ToT (= trunk,
I think e.g. http://chromegw/i/chromium.webrtc/waterfall should have similar
setup for some test cases). Henrik Kjellander will help out with the bot side of
things.

Here is pretty much how the workspace would need to be configured (or something
equivalent. There might be some minor changes as I'm landing
http://webrtc-codereview.appspot.com/1738004/ in WebRTC):
* Download chromium android workspace using the normal steps.
* Remove webrtc from .DEPS.git or DEPS (depending on how the workspace was set
up git/svn)
* Run ". build/android/envsetup.sh"
* GYP_DEFINES=$GYP_DEFINES' include_tests=1' (this will ensure that the
third_party/resources will be downloaded and the WebRTC tests will be available)
* Add the following lines to .gclient:
"
{ "name"        : "src/third_party/webrtc",
    "url"         : "https://webrtc.googlecode.com/svn/trunk/webrtc",
    "deps_file"   : "DEPS",
    "managed"     : True,
    "custom_deps" : {
    },
    "safesync_url": "",
  },
{ "name"        : "src/third_party/data",
    "url"         : "https://webrtc.googlecode.com/svn/trunk/data",
    "deps_file"   : "DEPS",
    "managed"     : True,
    "custom_deps" : {
    },
    "safesync_url": "",
  },
  { "name"        : "src/third_party/google-gflags",
    "url"         :
"https://webrtc.googlecode.com/svn/trunk/third_party/google-gflags",
    "deps_file"   : "DEPS",
    "managed"     : True,
    "custom_deps" : {
    },
    "safesync_url": "",
  },
  { "name"        : "src/third_party/google-gflags/src",
    "url"         : "https://google-gflags.googlecode.com/svn/trunk/src",
    "deps_file"   : "DEPS",
    "managed"     : True,
    "custom_deps" : {
    },
    "safesync_url": "",
  },
"

+    return [
+        'third_party/resources',
+        'third_party/data',

[frankf, 2013/07/01 18:32:38]

I don't see these thirdparty directories in my chromium checkout? Also, how
large are these directories? 

[hellner1, 2013/07/02 14:49:25]

third_party/resources (214.8 MB) are loaded from a remote (to Chrome and WebRTC)
repository by this script:
https://code.google.com/p/webrtc/source/browse/trunk/webrtc/tools/update.py
(which is about to be renamed to update_resources.py). This is a gyp-action when
building module_unittests which only happens if 
"include_tests==1".

third_party/data (31.8 MB) is from here:
https://code.google.com/p/webrtc/source/browse/#svn%2Ftrunk%2Fdata

[frankf, 2013/07/02 17:20:24]

200MB is a large amount of data to push to the device, and it may cause
timeouts. Is it possible to prune this?

On 2013/07/02 14:49:25, hellner1 wrote:

+    ]
   return []
 
 
 def _GetOptionalDataFilesForTestSuite(test_suite_basename):
   """Returns a list of data files/dirs that are pushed if present.
 
   Args:
     test_suite_basename: The test suite basename for which to return file paths.
 
   Returns:
@@ skipping 164 matching lines @@
       self.LaunchChromeTestServerSpawner()
     self.tool.SetupEnvironment()
 
   #override
   def TearDown(self):
     """Cleans up the test enviroment for the test suite."""
     self.tool.CleanUpEnvironment()
     if self._cleanup_test_files:
       self.adb.RemovePushedFiles()
     super(TestRunner, self).TearDown()