Simplify SVGTextContentElement::elementFromRenderer()

Simplify SVGTextContentElement::elementFromRenderer()

Simplify SVGTextContentElement::elementFromRenderer() by leveraging
SVGElement::isTextContent() methods instead of explicitly checking
for tag names.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153348

[Stephen Chennney, 2013-07-01 13:55:16]

Just one nit.

https://codereview.chromium.org/18358002/diff/1/Source/core/svg/SVGTextConten...
File Source/core/svg/SVGTextContentElement.cpp (left):

https://codereview.chromium.org/18358002/diff/1/Source/core/svg/SVGTextConten...
Source/core/svg/SVGTextContentElement.cpp:305: ASSERT(node);
Leave these 2 lines. We still want to catch cases where the node does not exist
(unlikely as it may seem).

[do-not-use, 2013-07-01 13:58:59]

https://codereview.chromium.org/18358002/diff/1/Source/core/svg/SVGTextConten...
File Source/core/svg/SVGTextContentElement.cpp (left):

https://codereview.chromium.org/18358002/diff/1/Source/core/svg/SVGTextConten...
Source/core/svg/SVGTextContentElement.cpp:305: ASSERT(node);
On 2013/07/01 13:55:16, Stephen Chenney wrote:
> Leave these 2 lines. We still want to catch cases where the node does not
exist
> (unlikely as it may seem).

ASSERT(element) would cover that case in the new patch.

ASSERT(node->isSVGElement()); is covered by toSVGElement() in the new patch as
it has the following assertion:
ASSERT_WITH_SECURITY_IMPLICATION(!node || node->isSVGElement());

[Stephen Chennney, 2013-07-01 14:09:54]

lgtm

https://codereview.chromium.org/18358002/diff/1/Source/core/svg/SVGTextConten...
File Source/core/svg/SVGTextContentElement.cpp (left):

https://codereview.chromium.org/18358002/diff/1/Source/core/svg/SVGTextConten...
Source/core/svg/SVGTextContentElement.cpp:305: ASSERT(node);
You're right. That's what I get for reviewing before breakfast.

On 2013/07/01 13:58:59, cdumez wrote:
> On 2013/07/01 13:55:16, Stephen Chenney wrote:
> > Leave these 2 lines. We still want to catch cases where the node does not
> exist
> > (unlikely as it may seem).
> 
> ASSERT(element) would cover that case in the new patch.
> 
> ASSERT(node->isSVGElement()); is covered by toSVGElement() in the new patch as
> it has the following assertion:
> ASSERT_WITH_SECURITY_IMPLICATION(!node || node->isSVGElement());

[commit-bot: I haz the power, 2013-07-01 14:10:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18358002/1

[commit-bot: I haz the power, 2013-07-01 15:33:29]

Change committed as 153348