third_party/WebKit/Source/core/html/HTMLObjectElement.cpp - Issue 1835773002: Rename AtomicString::string() to AtomicString::getString().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

Issue 1835773002: Rename AtomicString::string() to AtomicString::getString(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Windows Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp ('k') | third_party/WebKit/Source/core/html/HTMLScriptElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp b/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

index 892daef7f30d150785fb84a58e126704f56de8c4..28ffcd99004142fd8fbe956ca8cc26993d575bb5 100644

--- a/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

@@ -189,8 +189,8 @@ void HTMLObjectElement::parametersForPlugin(Vector<String>& paramNames, Vector<S

for (const Attribute& attribute : attributes) {

const AtomicString& name = attribute.name().localName();

if (!uniqueParamNames.contains(name.impl())) {

- paramNames.append(name.string());

- paramValues.append(attribute.value().string());

+ paramNames.append(name.getString());

+ paramValues.append(attribute.value().getString());

}

@@ -406,7 +406,7 @@ bool HTMLObjectElement::containsJavaApplet() const

for (HTMLElement& child : Traversal<HTMLElement>::childrenOf(*this)) {

if (isHTMLParamElement(child)

&& equalIgnoringCase(child.getNameAttribute(), "type")

- && MIMETypeRegistry::isJavaAppletMIMEType(child.getAttribute(valueAttr).string()))

+ && MIMETypeRegistry::isJavaAppletMIMEType(child.getAttribute(valueAttr).getString()))

return true;

if (isHTMLObjectElement(child) && toHTMLObjectElement(child).containsJavaApplet())

return true;