third_party/WebKit/Source/core/dom/custom/CustomElement.cpp - Issue 1835773002: Rename AtomicString::string() to AtomicString::getString().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElement.cpp

Issue 1835773002: Rename AtomicString::string() to AtomicString::getString(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Windows Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/SpaceSplitString.cpp ('k') | third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElement.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElement.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElement.cpp

index b85a3e43790934570de9a2cfeee71bf4e6c6b83d..36d0f12be68e4ffcb9e106e60a4ac86b24fe746c 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElement.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElement.cpp

@@ -70,7 +70,7 @@ static inline bool isValidNCName(const AtomicString& name)

if (kNotFound != name.find(':'))

return false;

- if (!name.string().is8Bit()) {

+ if (!name.getString().is8Bit()) {

const UChar32 c = name.characters16()[0];

// These characters comes under CombiningChar in NCName and according to

// NCName only BaseChar and Ideodgraphic can come as first chars.

@@ -80,7 +80,7 @@ static inline bool isValidNCName(const AtomicString& name)

return false;

}

- return Document::isValidName(name.string());

+ return Document::isValidName(name.getString());

}

bool CustomElement::isValidName(const AtomicString& name, NameSet validNames)