third_party/WebKit/Source/core/css/CSSSelector.cpp - Issue 1835773002: Rename AtomicString::string() to AtomicString::getString().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSSelector.cpp

Issue 1835773002: Rename AtomicString::string() to AtomicString::getString(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Windows Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/make_css_property_names.py ('k') | third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSSelector.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSSelector.cpp b/third_party/WebKit/Source/core/css/CSSSelector.cpp

index c69db5ad739a79b7b965facaaf3734d1a840534c..0ea6dcc4fa17c71d68359b71f4b5141de1634fba 100644

--- a/third_party/WebKit/Source/core/css/CSSSelector.cpp

+++ b/third_party/WebKit/Source/core/css/CSSSelector.cpp

@@ -403,7 +403,7 @@ static CSSSelector::PseudoType nameToPseudoType(const AtomicString& name, bool h

}

NameToPseudoStruct dummyKey = { 0, CSSSelector::PseudoUnknown };

const NameToPseudoStruct* match = std::lower_bound(pseudoTypeMap, pseudoTypeMapEnd, dummyKey, NameToPseudoCompare(name));

- if (match == pseudoTypeMapEnd || match->string != name.string())

+ if (match == pseudoTypeMapEnd || match->string != name.getString())

return CSSSelector::PseudoUnknown;

return static_cast<CSSSelector::PseudoType>(match->type);

@@ -595,7 +595,7 @@ String CSSSelector::selectorText(const String& rightSide) const

if (tagQName().prefix().isNull()) {

str.append(tagQName().localName());

} else {

- str.append(tagQName().prefix().string());

+ str.append(tagQName().prefix().getString());

str.append('|');

str.append(tagQName().localName());

}