Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

Issue 1835773002: Rename AtomicString::string() to AtomicString::getString(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Windows Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 stripped.append(character); 132 stripped.append(character);
133 } 133 }
134 return stripped.toString(); 134 return stripped.toString();
135 } 135 }
136 136
137 static bool isNotLineBreak(UChar ch) { return ch != newlineCharacter && ch != ca rriageReturnCharacter; } 137 static bool isNotLineBreak(UChar ch) { return ch != newlineCharacter && ch != ca rriageReturnCharacter; }
138 138
139 bool HTMLTextFormControlElement::isPlaceholderEmpty() const 139 bool HTMLTextFormControlElement::isPlaceholderEmpty() const
140 { 140 {
141 const AtomicString& attributeValue = fastGetAttribute(placeholderAttr); 141 const AtomicString& attributeValue = fastGetAttribute(placeholderAttr);
142 return attributeValue.string().find(isNotLineBreak) == kNotFound; 142 return attributeValue.getString().find(isNotLineBreak) == kNotFound;
143 } 143 }
144 144
145 bool HTMLTextFormControlElement::placeholderShouldBeVisible() const 145 bool HTMLTextFormControlElement::placeholderShouldBeVisible() const
146 { 146 {
147 return supportsPlaceholder() 147 return supportsPlaceholder()
148 && isEmptyValue() 148 && isEmptyValue()
149 && isEmptySuggestedValue() 149 && isEmptySuggestedValue()
150 && !isPlaceholderEmpty(); 150 && !isPlaceholderEmpty();
151 } 151 }
152 152
(...skipping 875 matching lines...) Expand 10 before | Expand all | Expand 10 after
1028 } 1028 }
1029 1029
1030 void HTMLTextFormControlElement::copyNonAttributePropertiesFromElement(const Ele ment& source) 1030 void HTMLTextFormControlElement::copyNonAttributePropertiesFromElement(const Ele ment& source)
1031 { 1031 {
1032 const HTMLTextFormControlElement& sourceElement = static_cast<const HTMLText FormControlElement&>(source); 1032 const HTMLTextFormControlElement& sourceElement = static_cast<const HTMLText FormControlElement&>(source);
1033 m_lastChangeWasUserEdit = sourceElement.m_lastChangeWasUserEdit; 1033 m_lastChangeWasUserEdit = sourceElement.m_lastChangeWasUserEdit;
1034 HTMLFormControlElement::copyNonAttributePropertiesFromElement(source); 1034 HTMLFormControlElement::copyNonAttributePropertiesFromElement(source);
1035 } 1035 }
1036 1036
1037 } // namespace blink 1037 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLSelectElement.cpp ('k') | third_party/WebKit/Source/core/html/forms/InputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698