Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp

Issue 1835773002: Rename AtomicString::string() to AtomicString::getString(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Windows Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de) 4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de)
5 * Copyright (C) 2004, 2005, 2006, 2008, 2009, 2011 Apple Inc. All rights reserv ed. 5 * Copyright (C) 2004, 2005, 2006, 2008, 2009, 2011 Apple Inc. All rights reserv ed.
6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 } 110 }
111 } else { 111 } else {
112 HTMLPlugInElement::parseAttribute(name, oldValue, value); 112 HTMLPlugInElement::parseAttribute(name, oldValue, value);
113 } 113 }
114 } 114 }
115 115
116 void HTMLEmbedElement::parametersForPlugin(Vector<String>& paramNames, Vector<St ring>& paramValues) 116 void HTMLEmbedElement::parametersForPlugin(Vector<String>& paramNames, Vector<St ring>& paramValues)
117 { 117 {
118 AttributeCollection attributes = this->attributes(); 118 AttributeCollection attributes = this->attributes();
119 for (const Attribute& attribute : attributes) { 119 for (const Attribute& attribute : attributes) {
120 paramNames.append(attribute.localName().string()); 120 paramNames.append(attribute.localName().getString());
121 paramValues.append(attribute.value().string()); 121 paramValues.append(attribute.value().getString());
122 } 122 }
123 } 123 }
124 124
125 // FIXME: This should be unified with HTMLObjectElement::updateWidget and 125 // FIXME: This should be unified with HTMLObjectElement::updateWidget and
126 // moved down into HTMLPluginElement.cpp 126 // moved down into HTMLPluginElement.cpp
127 void HTMLEmbedElement::updateWidgetInternal() 127 void HTMLEmbedElement::updateWidgetInternal()
128 { 128 {
129 ASSERT(!layoutEmbeddedItem().showsUnavailablePluginIndicator()); 129 ASSERT(!layoutEmbeddedItem().showsUnavailablePluginIndicator());
130 ASSERT(needsWidgetUpdate()); 130 ASSERT(needsWidgetUpdate());
131 setNeedsWidgetUpdate(false); 131 setNeedsWidgetUpdate(false);
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 { 201 {
202 // http://www.whatwg.org/specs/web-apps/current-work/#exposed 202 // http://www.whatwg.org/specs/web-apps/current-work/#exposed
203 for (HTMLObjectElement* object = Traversal<HTMLObjectElement>::firstAncestor (*this); object; object = Traversal<HTMLObjectElement>::firstAncestor(*object)) { 203 for (HTMLObjectElement* object = Traversal<HTMLObjectElement>::firstAncestor (*this); object; object = Traversal<HTMLObjectElement>::firstAncestor(*object)) {
204 if (object->isExposed()) 204 if (object->isExposed())
205 return false; 205 return false;
206 } 206 }
207 return true; 207 return true;
208 } 208 }
209 209
210 } // namespace blink 210 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698