chrome/renderer/content_settings_observer.h - Issue 1835753002: Reset content settings caches during provisional load start instead of commit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/content_settings_observer.h

Issue 1835753002: Reset content settings caches during provisional load start instead of commit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move things under DidCreateNewDocument instead of DidStartProvisionalLoad Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/content_settings_observer.h

diff --git a/chrome/renderer/content_settings_observer.h b/chrome/renderer/content_settings_observer.h

index 8e1668606b5220b96bb6d9d9c936e1ea0c373adc..6ea041a40a231e34d4b4a4a55c2f1fddb85fd970 100644

--- a/chrome/renderer/content_settings_observer.h

+++ b/chrome/renderer/content_settings_observer.h

@@ -96,6 +96,7 @@ class ContentSettingsObserver

// RenderFrameObserver implementation.

bool OnMessageReceived(const IPC::Message& message) override;

+ void DidCreateNewDocument() override;

void DidCommitProvisionalLoad(bool is_new_navigation,

bool is_same_page_navigation) override;

« no previous file with comments | « no previous file | chrome/renderer/content_settings_observer.cc » ('j') | chrome/renderer/content_settings_observer.cc » ('J')