Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Side by Side Diff: src/runtime.cc

Issue 18357004: Revert r15419: "Generate StoreGlobal stubs with Hydrogen" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects-inl.h ('k') | src/stub-cache.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2092 matching lines...) Expand 10 before | Expand all | Expand 10 after
2103 // Strict mode handling not needed (const is disallowed in strict mode). 2103 // Strict mode handling not needed (const is disallowed in strict mode).
2104 if (lookup.IsField()) { 2104 if (lookup.IsField()) {
2105 FixedArray* properties = global->properties(); 2105 FixedArray* properties = global->properties();
2106 int index = lookup.GetFieldIndex().field_index(); 2106 int index = lookup.GetFieldIndex().field_index();
2107 if (properties->get(index)->IsTheHole() || !lookup.IsReadOnly()) { 2107 if (properties->get(index)->IsTheHole() || !lookup.IsReadOnly()) {
2108 properties->set(index, *value); 2108 properties->set(index, *value);
2109 } 2109 }
2110 } else if (lookup.IsNormal()) { 2110 } else if (lookup.IsNormal()) {
2111 if (global->GetNormalizedProperty(&lookup)->IsTheHole() || 2111 if (global->GetNormalizedProperty(&lookup)->IsTheHole() ||
2112 !lookup.IsReadOnly()) { 2112 !lookup.IsReadOnly()) {
2113 HandleScope scope(isolate);
2114 global->SetNormalizedProperty(&lookup, *value); 2113 global->SetNormalizedProperty(&lookup, *value);
2115 } 2114 }
2116 } else { 2115 } else {
2117 // Ignore re-initialization of constants that have already been 2116 // Ignore re-initialization of constants that have already been
2118 // assigned a function value. 2117 // assigned a function value.
2119 ASSERT(lookup.IsReadOnly() && lookup.IsConstantFunction()); 2118 ASSERT(lookup.IsReadOnly() && lookup.IsConstantFunction());
2120 } 2119 }
2121 2120
2122 // Use the set value as the result of the operation. 2121 // Use the set value as the result of the operation.
2123 return *value; 2122 return *value;
(...skipping 11824 matching lines...) Expand 10 before | Expand all | Expand 10 after
13948 // Handle last resort GC and make sure to allow future allocations 13947 // Handle last resort GC and make sure to allow future allocations
13949 // to grow the heap without causing GCs (if possible). 13948 // to grow the heap without causing GCs (if possible).
13950 isolate->counters()->gc_last_resort_from_js()->Increment(); 13949 isolate->counters()->gc_last_resort_from_js()->Increment();
13951 isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags, 13950 isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags,
13952 "Runtime::PerformGC"); 13951 "Runtime::PerformGC");
13953 } 13952 }
13954 } 13953 }
13955 13954
13956 13955
13957 } } // namespace v8::internal 13956 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects-inl.h ('k') | src/stub-cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698