Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1835693002: Remove FX_DWORD from fpdfsdk/ and testing/ (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove FX_DWORD from fpdfsdk/ and testing BUG= Committed: https://pdfium.googlesource.com/pdfium/+/c3255f55954b2adc3edbd3269c0a8779f7d4b7ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+445 lines, -445 lines) Patch
M fpdfsdk/formfiller/cffl_formfiller.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/formfiller/cffl_iformfiller.h View 3 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/formfiller/cffl_iformfiller.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/formfiller/cffl_listbox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_pushbutton.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_pushbutton.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_dataavail.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdf_ext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdf_flatten.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/fpdf_sysfontinfo.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/fpdf_transformpage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfdoc_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfppo.cpp View 8 chunks +12 lines, -12 lines 0 comments Download
M fpdfsdk/fpdfsave.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfview.cpp View 7 chunks +11 lines, -11 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_app.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_util.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fsdk_annothandler.cpp View 41 chunks +47 lines, -47 lines 0 comments Download
M fpdfsdk/fsdk_baseannot.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/fsdk_baseform.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/fsdk_mgr.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/fxedit/fxet_ap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fxedit/fxet_edit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fpdfxfa/fpdfxfa_app.h View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h View 3 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/include/fpdfxfa/fpdfxfa_util.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_annothandler.h View 6 chunks +63 lines, -63 lines 0 comments Download
M fpdfsdk/include/fsdk_baseannot.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/fsdk_define.h View 3 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 2 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/include/fx_systemhandler.h View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/javascript/Document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/Field.h View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/Field.cpp View 12 chunks +12 lines, -12 lines 0 comments Download
M fpdfsdk/javascript/JS_GlobalData.cpp View 8 chunks +26 lines, -26 lines 0 comments Download
M fpdfsdk/javascript/JS_Object.h View 2 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/javascript/JS_Object.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/JS_Value.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/app.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Button.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Button.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ComboBox.h View 3 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ComboBox.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Edit.h View 3 chunks +10 lines, -10 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Edit.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_EditCtrl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_EditCtrl.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Icon.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_IconList.h View 2 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_IconList.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ListBox.h View 2 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ListBox.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Note.h View 5 chunks +12 lines, -12 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Note.cpp View 12 chunks +12 lines, -12 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ScrollBar.h View 2 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ScrollBar.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_SpecialButton.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_SpecialButton.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Utils.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Wnd.h View 5 chunks +22 lines, -22 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Wnd.cpp View 9 chunks +11 lines, -11 lines 0 comments Download
M testing/libfuzzer/pdf_jpx_fuzzer.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Oliver, same thing.
4 years, 9 months ago (2016-03-25 21:21:19 UTC) #2
Oliver Chang
same lgtm
4 years, 9 months ago (2016-03-25 21:21:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1835693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1835693002/1
4 years, 9 months ago (2016-03-25 21:22:52 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 21:52:31 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/c3255f55954b2adc3edbd3269c0a8779f7d4...

Powered by Google App Engine
This is Rietveld 408576698