Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1835653002: Turn on standard logging details in Mojo app runners (Closed)

Created:
4 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 9 months ago
Reviewers:
jam, sky
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), kalyank, qsr+mojo_chromium.org, sadrul, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn on standard logging details in Mojo app runners It's not clear why Mojo runner disabled these, and I think the mash runner just copied whatever the Mojo runner was doing. BUG=None Committed: https://crrev.com/317d7f244dbda5394b1f05a38bdb0938ec9fb7e1 Cr-Commit-Position: refs/heads/master@{#383373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/app/mash/mash_runner.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/shell/runner/init.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Ken Rockot(use gerrit already)
Do you know of any reason why we should leave these off?
4 years, 9 months ago (2016-03-25 19:41:42 UTC) #2
sky
To make it harder to debug failures? I can't think of a good reason. Not ...
4 years, 9 months ago (2016-03-25 20:38:02 UTC) #4
jam
On 2016/03/25 20:38:02, sky wrote: > To make it harder to debug failures? > > ...
4 years, 9 months ago (2016-03-25 21:41:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1835653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1835653002/1
4 years, 9 months ago (2016-03-25 21:42:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-25 21:48:28 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 21:49:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/317d7f244dbda5394b1f05a38bdb0938ec9fb7e1
Cr-Commit-Position: refs/heads/master@{#383373}

Powered by Google App Engine
This is Rietveld 408576698