Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: runtime/bin/main.cc

Issue 1835633002: Precompilation: (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: sync Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/dart.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/main.cc
diff --git a/runtime/bin/main.cc b/runtime/bin/main.cc
index 719661e496124fc7333d8b1d507fdcee15495a5e..68eb17d207fdce1d8bff0beca766d5f74016bdf9 100644
--- a/runtime/bin/main.cc
+++ b/runtime/bin/main.cc
@@ -812,9 +812,12 @@ static Dart_Isolate CreateIsolateAndSetupHelper(const char* script_uri,
result = DartUtils::PrepareForScriptLoading(false, trace_loading);
CHECK_RESULT(result);
- if (run_service_isolate) {
+ if (!run_precompiled_snapshot && !run_full_snapshot) {
// Set up the load port provided by the service isolate so that we can
// load scripts.
+ // With a full snapshot or a precompiled snapshot in product mode, there is
+ // no service isolate. A precompiled snapshot in release or debug mode does
+ // have the service isolate, but it doesn't use it for loading.
result = DartUtils::SetupServiceLoadPort();
CHECK_RESULT(result);
}
« no previous file with comments | « no previous file | runtime/vm/dart.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698