Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 1835633002: Precompilation: (Closed)

Created:
4 years, 9 months ago by rmacnak
Modified:
4 years, 8 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Precompilation: - Fix crash sending full class responses. - Don't wait for service isolate startup. - Add timeline events for deserializing and premarking the VM isolate. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/f0d4f3151c22027e9907dd7d2a31a3aa7a125bb3

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M runtime/bin/main.cc View 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/dart.cc View 1 2 chunks +7 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
4 years, 9 months ago (2016-03-25 19:38:06 UTC) #2
rmacnak
PTAL
4 years, 8 months ago (2016-03-29 18:16:31 UTC) #3
Cutch
lgtm
4 years, 8 months ago (2016-03-29 18:29:43 UTC) #4
rmacnak
4 years, 8 months ago (2016-03-29 19:30:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f0d4f3151c22027e9907dd7d2a31a3aa7a125bb3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698