sync: reland deferred init

sync: reland deferred init

TBR=nyquist@chromium.org
BUG=80194, 348951
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255890

[rlarocque, 2014-03-07 20:00:27]

https://codereview.chromium.org/183563004/diff/60001/chrome/browser/sync/star...
File chrome/browser/sync/startup_controller.cc (right):

https://codereview.chromium.org/183563004/diff/60001/chrome/browser/sync/star...
chrome/browser/sync/startup_controller.cc:55:
base::StringToInt(CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
Could you check the return value?  And maybe sanity-check the value you get
back, too?  (eg. fail if the value is negative)

[shashi, 2014-03-07 20:03:24]

SyncTest.py: lgtm

[tim (not reviewing), 2014-03-07 20:45:53]

+nyquist for SyncTest.py OWNERs

Richard, comment addressed.

[rlarocque, 2014-03-07 20:49:21]

lgtm

https://codereview.chromium.org/183563004/diff/100001/chrome/browser/sync/sta...
File chrome/browser/sync/startup_controller.cc (right):

https://codereview.chromium.org/183563004/diff/100001/chrome/browser/sync/sta...
chrome/browser/sync/startup_controller.cc:60: fallback_timeout_ =
base::TimeDelta::FromSeconds(timeout);
nit: I'd recommend adding a log message here.  Because the effects of the flag
are subtle and both success and failure are silent, you might have trouble
debugging this otherwise.

[tim (not reviewing), 2014-03-07 20:59:28]

done, TBR'ing Tommy based on Shashi's approval of adding the command line flag
to SyncTest.py

Thanks!

https://codereview.chromium.org/183563004/diff/100001/chrome/browser/sync/sta...
File chrome/browser/sync/startup_controller.cc (right):

https://codereview.chromium.org/183563004/diff/100001/chrome/browser/sync/sta...
chrome/browser/sync/startup_controller.cc:60: fallback_timeout_ =
base::TimeDelta::FromSeconds(timeout);
On 2014/03/07 20:49:22, rlarocque wrote:
> nit: I'd recommend adding a log message here.  Because the effects of the flag
> are subtle and both success and failure are silent, you might have trouble
> debugging this otherwise.

Done.

[tim (not reviewing), 2014-03-07 20:59:54]

The CQ bit was checked by tim@chromium.org

[commit-bot: I haz the power, 2014-03-07 21:01:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tim@chromium.org/183563004/110001

[nyquist, 2014-03-07 23:59:58]

lgtm

[commit-bot: I haz the power, 2014-03-08 10:57:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tim@chromium.org/183563004/110001

[commit-bot: I haz the power, 2014-03-08 13:48:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-08 13:48:35]

Retried try job too often on mac_rel for step(s) telemetry_perf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[tim (not reviewing), 2014-03-08 19:45:07]

The CQ bit was checked by tim@chromium.org

[commit-bot: I haz the power, 2014-03-08 19:45:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tim@chromium.org/183563004/110001

[commit-bot: I haz the power, 2014-03-08 20:28:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-08 20:28:25]

Retried try job too often on mac_rel for step(s) telemetry_perf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[tim (not reviewing), 2014-03-10 02:20:38]

The CQ bit was checked by tim@chromium.org

[commit-bot: I haz the power, 2014-03-10 02:20:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tim@chromium.org/183563004/110001

[commit-bot: I haz the power, 2014-03-10 06:44:55]

Change committed as 255890