Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 183563003: cc: Clean up OcclusionTracker template parameters. (Closed)

Created:
6 years, 9 months ago by danakj
Modified:
6 years, 9 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, feature-media-reviews_chromium.org, cc-bugs_chromium.org, piman
Visibility:
Public.

Description

cc: Clean up OcclusionTracker template parameters. Currently it takes LayerType and RenderSurfaceType, but the latter is derivable from the former, so just pass the former. Since there's only one parameter, it's clearer to use OcclusionTracker<Layer(Impl)> directly instead of using typedefs. Also rename the TestOcclusionTracker file from occlusion_tracker_test_common.h to test_occlusion_tracker.h. R=enne BUG=344962 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254965

Patch Set 1 #

Patch Set 2 : occlusionparams: #

Patch Set 3 : occlusionparams: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -331 lines) Patch
M cc/cc_tests.gyp View 2 chunks +1 line, -1 line 0 comments Download
M cc/debug/debug_rect_history.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/content_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/content_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/contents_scaling_layer.h View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/layers/contents_scaling_layer.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/layers/delegated_renderer_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/delegated_renderer_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/image_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/image_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/io_surface_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/io_surface_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer.h View 3 chunks +3 lines, -2 lines 0 comments Download
M cc/layers/layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/nine_patch_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/painted_scrollbar_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/painted_scrollbar_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer.h View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/layers/picture_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M cc/layers/texture_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/texture_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/tiled_layer.h View 3 chunks +9 lines, -8 lines 0 comments Download
M cc/layers/tiled_layer.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M cc/layers/tiled_layer_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M cc/layers/ui_resource_layer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/video_layer.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/video_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_content_layer.h View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/test/fake_content_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_painted_scrollbar_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_painted_scrollbar_layer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/test/fake_picture_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_picture_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/layer_tree_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
D cc/test/occlusion_tracker_test_common.h View 1 chunk +0 lines, -50 lines 0 comments Download
A cc/test/test_occlusion_tracker.h View 1 1 chunk +44 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.h View 2 chunks +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 5 chunks +9 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_occlusion.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/occlusion_tracker.h View 2 chunks +8 lines, -10 lines 0 comments Download
M cc/trees/occlusion_tracker.cc View 13 chunks +48 lines, -45 lines 0 comments Download
M cc/trees/occlusion_tracker_perftest.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 52 chunks +56 lines, -107 lines 0 comments Download
M cc/trees/quad_culler.h View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/quad_culler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/quad_culler_unittest.cc View 19 chunks +49 lines, -31 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
danakj
6 years, 9 months ago (2014-03-04 21:19:04 UTC) #1
enne (OOO)
lgtm
6 years, 9 months ago (2014-03-04 23:19:39 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-04 23:20:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/183563003/40001
6 years, 9 months ago (2014-03-04 23:22:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/183563003/40001
6 years, 9 months ago (2014-03-05 01:16:11 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 06:55:05 UTC) #6
Message was sent while issue was closed.
Change committed as 254965

Powered by Google App Engine
This is Rietveld 408576698