Adapt the Java LoadUrlParams for the Chrome embedder.

Adapt the Java LoadUrlParams for the Chrome embedder.

This patch modifies the Java holder for url load parameters already used
in WebView so that it can be used in Chrome for Android as well:
- adds a getter for post data
- makes the url mutable like the other fields (to allow for
  sanitizations while passing the struct down the stack - maybe that's
  not ideal but that's what we do)
- adds a field for verbatim extra headers string

BUG=346290
R=tedchoc@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254134

[ppi, 2014-02-27 18:30:33]

Please take a look.

[Ted C, 2014-02-27 21:20:03]

lgtm w/ a long winded comment

https://codereview.chromium.org/183563002/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/LoadUrlParams.java
(right):

https://codereview.chromium.org/183563002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/LoadUrlParams.java:269:
* @return the verbatim extra headers string
it might be worth calling out here and in getExtraHeadersString that they don't
contain the other values.

I'm somewhat curious what it would take for use to start using the Map<String,
String> version as well.  I.e. how many usages of extra headers do we have and
could we make it use the map format like above.

Might be intractable, but it would be nice to have one method (but only if we
wouldn't have to take headers as a string and split them into the map format
just to recombine them).  If I recall, we might accept additional headers in
certain intent cases, so maybe that makes it a non-starter and the extra
documentation is the best we can do.

[ppi, 2014-02-28 12:14:14]

Thanks, Ted! Please see the reply below.

https://codereview.chromium.org/183563002/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/LoadUrlParams.java
(right):

https://codereview.chromium.org/183563002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/LoadUrlParams.java:269:
* @return the verbatim extra headers string
On 2014/02/27 21:20:03, Ted C wrote:
> it might be worth calling out here and in getExtraHeadersString that they
don't
> contain the other values.
> 
> I'm somewhat curious what it would take for use to start using the Map<String,
> String> version as well.  I.e. how many usages of extra headers do we have and
> could we make it use the map format like above.
> 
> Might be intractable, but it would be nice to have one method (but only if we
> wouldn't have to take headers as a string and split them into the map format
> just to recombine them).  If I recall, we might accept additional headers in
> certain intent cases, so maybe that makes it a non-starter and the extra
> documentation is the best we can do.

Added the comments in patch set 2.

I agree it would be nice to switch to Map<String, String> as long as we don't
need to explode the string ourselves. I looked into it a bit and spawned
http://crbug.com/347955 to track it.

[ppi, 2014-02-28 12:14:57]

The CQ bit was checked by ppi@chromium.org

[commit-bot: I haz the power, 2014-02-28 12:15:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ppi@chromium.org/183563002/10001

[commit-bot: I haz the power, 2014-02-28 13:59:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-28 13:59:09]

Retried try job too often on android_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[ppi, 2014-02-28 15:44:09]

Committed patchset #3 manually as r254134 (presubmit successful).