Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: runtime/vm/intrinsifier_arm64.cc

Issue 1835583002: VM: Use delay slot in two places in MIPS intrinis code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/intrinsifier_arm.cc ('k') | runtime/vm/intrinsifier_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64.
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/intrinsifier.h" 8 #include "vm/intrinsifier.h"
9 9
10 #include "vm/assembler.h" 10 #include "vm/assembler.h"
(...skipping 1404 matching lines...) Expand 10 before | Expand all | Expand 10 after
1415 } 1415 }
1416 const Class& double_class = Class::Handle( 1416 const Class& double_class = Class::Handle(
1417 Isolate::Current()->object_store()->double_class()); 1417 Isolate::Current()->object_store()->double_class());
1418 __ TryAllocate(double_class, &fall_through, R0, R1); 1418 __ TryAllocate(double_class, &fall_through, R0, R1);
1419 __ StoreDFieldToOffset(V0, R0, Double::value_offset()); 1419 __ StoreDFieldToOffset(V0, R0, Double::value_offset());
1420 __ ret(); 1420 __ ret();
1421 1421
1422 __ Bind(&is_smi); // Convert R0 to a double. 1422 __ Bind(&is_smi); // Convert R0 to a double.
1423 __ SmiUntag(R0); 1423 __ SmiUntag(R0);
1424 __ scvtfdx(V1, R0); 1424 __ scvtfdx(V1, R0);
1425 __ b(&double_op); // Then do the comparison. 1425 __ b(&double_op);
1426 1426
1427 __ Bind(&fall_through); 1427 __ Bind(&fall_through);
1428 } 1428 }
1429 1429
1430 1430
1431 void Intrinsifier::Double_add(Assembler* assembler) { 1431 void Intrinsifier::Double_add(Assembler* assembler) {
1432 DoubleArithmeticOperations(assembler, Token::kADD); 1432 DoubleArithmeticOperations(assembler, Token::kADD);
1433 } 1433 }
1434 1434
1435 1435
(...skipping 774 matching lines...) Expand 10 before | Expand all | Expand 10 after
2210 2210
2211 void Intrinsifier::Profiler_getCurrentTag(Assembler* assembler) { 2211 void Intrinsifier::Profiler_getCurrentTag(Assembler* assembler) {
2212 __ LoadIsolate(R0); 2212 __ LoadIsolate(R0);
2213 __ ldr(R0, Address(R0, Isolate::current_tag_offset())); 2213 __ ldr(R0, Address(R0, Isolate::current_tag_offset()));
2214 __ ret(); 2214 __ ret();
2215 } 2215 }
2216 2216
2217 } // namespace dart 2217 } // namespace dart
2218 2218
2219 #endif // defined TARGET_ARCH_ARM64 2219 #endif // defined TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « runtime/vm/intrinsifier_arm.cc ('k') | runtime/vm/intrinsifier_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698