MD Settings: show part of a11y page on Mac/Windows/Linux

MD Settings: show part of a11y page on Mac/Windows/Linux

R=tommycli@chromium.org
BUG=597880
Committed: https://crrev.com/5fe41f00c535ab1ec78b3cd2ba7fd13ae788807b
Cr-Commit-Position: refs/heads/master@{#383333}

[Dan Beam, 2016-03-25 02:05:18]

Description was changed from

==========
MD Settings: show part of a11y page on Mac/Windows/Linux

R=dmazzoni@chromium.org
BUG=597880
==========

to

==========
MD Settings: show part of a11y page on Mac/Windows/Linux

R=tommycli@chromium.org
BUG=597880
==========

[Dan Beam, 2016-03-25 02:05:18]

dbeam@chromium.org changed reviewers:
+ tommycli@chromium.org
- dmazzoni@chromium.org

[Dan Beam, 2016-03-25 02:05:57]

this is only exposing more existing functionality, BUT happy to add any tests we
can find useful

[tommycli, 2016-03-25 18:16:51]

lgtm sans nit:

https://codereview.chromium.org/1835533003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/a11y_page/a11y_page.html (right):

https://codereview.chromium.org/1835533003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/a11y_page/a11y_page.html:84: </if>
I had to do a double-take to understand the <if> structure in this file. Could
we if-out the whole first two divs as chromeos-only and change the last div to:

<if expr="chromeos">
  <div class="settings-box">
</if>
<if expr="not chromeos">
  <div class="settings-box row first">
</if>
?

[Dan Beam, 2016-03-25 18:49:17]

https://codereview.chromium.org/1835533003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/a11y_page/a11y_page.html (right):

https://codereview.chromium.org/1835533003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/a11y_page/a11y_page.html:84: </if>
On 2016/03/25 18:16:51, tommycli wrote:
> I had to do a double-take to understand the <if> structure in this file. Could
> we if-out the whole first two divs as chromeos-only and change the last div
to:
> 
> <if expr="chromeos">
>   <div class="settings-box">
> </if>
> <if expr="not chromeos">
>   <div class="settings-box row first">
> </if>
> ?

Done.

[Dan Beam, 2016-03-25 18:49:30]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-03-25 18:49:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/1835533003/#ps20001
(title: "tommycli@ review")

[commit-bot: I haz the power, 2016-03-25 18:49:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1835533003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1835533003/20001

[commit-bot: I haz the power, 2016-03-25 19:42:01]

Description was changed from

==========
MD Settings: show part of a11y page on Mac/Windows/Linux

R=tommycli@chromium.org
BUG=597880
==========

to

==========
MD Settings: show part of a11y page on Mac/Windows/Linux

R=tommycli@chromium.org
BUG=597880
==========

[commit-bot: I haz the power, 2016-03-25 19:42:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-25 19:43:16]

Description was changed from

==========
MD Settings: show part of a11y page on Mac/Windows/Linux

R=tommycli@chromium.org
BUG=597880
==========

to

==========
MD Settings: show part of a11y page on Mac/Windows/Linux

R=tommycli@chromium.org
BUG=597880

Committed: https://crrev.com/5fe41f00c535ab1ec78b3cd2ba7fd13ae788807b
Cr-Commit-Position: refs/heads/master@{#383333}
==========

[commit-bot: I haz the power, 2016-03-25 19:43:17]

Patchset 2 (id:??) landed as
https://crrev.com/5fe41f00c535ab1ec78b3cd2ba7fd13ae788807b
Cr-Commit-Position: refs/heads/master@{#383333}