cc: Add LayerTreeSetting to disable cached picture raster.

cc: Add LayerTreeSetting to disable cached picture raster.

PictureImageLayer currently uses cached picture by default since it was
used by GatherPixelRefs. This is no longer necessary since we now use
GenerateDiscardableImagesMetadata in DisplayItemList to build the image
map, which supports both modes.

BUG=597163
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/8e17a5b61e3e9a14939ebc10a152e108c2a0ba07
Cr-Commit-Position: refs/heads/master@{#384346}

[Khushal, 2016-03-25 00:54:28]

Description was changed from

==========
cc: Use --disable-cached-picture-raster to initialize
DisplayItemListSettings in PictureImageLayer.

PictureImageLayer currently uses cached picture by default since it was
used by GatherPixelRefs. This is no longer necessary since we now use
GenerateDiscardableImagesMetadata in DisplayItemList to build the image
map, which supports both modes.

BUG=597163
==========

to

==========
cc: Use --disable-cached-picture-raster to initialize
DisplayItemListSettings in PictureImageLayer.

PictureImageLayer currently uses cached picture by default since it was
used by GatherPixelRefs. This is no longer necessary since we now use
GenerateDiscardableImagesMetadata in DisplayItemList to build the image
map, which supports both modes.

BUG=597163
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Khushal, 2016-03-25 00:55:06]

khushalsagar@chromium.org changed reviewers:
+ vmpstr@chromium.org

[Khushal, 2016-03-25 21:15:00]

On 2016/03/25 00:55:06, Khushal wrote:

friendly ping. :)

[vmpstr, 2016-03-25 21:45:12]

https://codereview.chromium.org/1835523002/diff/1/cc/layers/picture_image_lay...
File cc/layers/picture_image_layer.cc (right):

https://codereview.chromium.org/1835523002/diff/1/cc/layers/picture_image_lay...
cc/layers/picture_image_layer.cc:23: static bool UseCachedPictureRaster() {
Is it possible to plumb this through layer tree settings? I don't really want to
set the precedent of checking the command line in our layers... The
web_content_layer_impl is kind of the blink interface, so I'm not sure if they
can access layer tree settings.

[danakj, 2016-03-25 21:46:13]

driveby: You can't line wrap the first line of a CL description, only the first
line counts.

[Khushal, 2016-03-25 21:52:53]

Description was changed from

==========
cc: Use --disable-cached-picture-raster to initialize
DisplayItemListSettings in PictureImageLayer.

PictureImageLayer currently uses cached picture by default since it was
used by GatherPixelRefs. This is no longer necessary since we now use
GenerateDiscardableImagesMetadata in DisplayItemList to build the image
map, which supports both modes.

BUG=597163
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Use --disable-cached-picture-raster in PictureImageLayer.

PictureImageLayer currently uses cached picture by default since it was
used by GatherPixelRefs. This is no longer necessary since we now use
GenerateDiscardableImagesMetadata in DisplayItemList to build the image
map, which supports both modes.

BUG=597163
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Khushal, 2016-03-25 21:53:12]

Description was changed from

==========
cc: Use --disable-cached-picture-raster in PictureImageLayer.

PictureImageLayer currently uses cached picture by default since it was
used by GatherPixelRefs. This is no longer necessary since we now use
GenerateDiscardableImagesMetadata in DisplayItemList to build the image
map, which supports both modes.

BUG=597163
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Use disable-cached-picture-raster in PictureImageLayer.

PictureImageLayer currently uses cached picture by default since it was
used by GatherPixelRefs. This is no longer necessary since we now use
GenerateDiscardableImagesMetadata in DisplayItemList to build the image
map, which supports both modes.

BUG=597163
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Khushal, 2016-03-25 21:53:48]

https://codereview.chromium.org/1835523002/diff/1/cc/layers/picture_image_lay...
File cc/layers/picture_image_layer.cc (right):

https://codereview.chromium.org/1835523002/diff/1/cc/layers/picture_image_lay...
cc/layers/picture_image_layer.cc:23: static bool UseCachedPictureRaster() {
On 2016/03/25 21:45:12, vmpstr wrote:
> Is it possible to plumb this through layer tree settings? I don't really want
to
> set the precedent of checking the command line in our layers... The
> web_content_layer_impl is kind of the blink interface, so I'm not sure if they
> can access layer tree settings.

Sure I can add a LayerTreeSetting for this. Yup, cc/blink wouldn't have any
access to it, so we would have to use the command line flag there.

[Khushal, 2016-03-25 21:54:04]

On 2016/03/25 21:46:13, danakj wrote:
> driveby: You can't line wrap the first line of a CL description, only the
first
> line counts.

Woopsie. Fixed that.

[Khushal, 2016-03-29 17:49:37]

Description was changed from

==========
cc: Use disable-cached-picture-raster in PictureImageLayer.

PictureImageLayer currently uses cached picture by default since it was
used by GatherPixelRefs. This is no longer necessary since we now use
GenerateDiscardableImagesMetadata in DisplayItemList to build the image
map, which supports both modes.

BUG=597163
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Add LayerTreeSetting to disable cached picture raster.

PictureImageLayer currently uses cached picture by default since it was
used by GatherPixelRefs. This is no longer necessary since we now use
GenerateDiscardableImagesMetadata in DisplayItemList to build the image
map, which supports both modes.

BUG=597163
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Khushal, 2016-03-29 17:49:37]

khushalsagar@chromium.org changed reviewers:
+ sievers@chromium.org

[Khushal, 2016-03-29 17:50:57]

Moved disabling cached picture raster to a LayerTreeSetting. PTAL.

[vmpstr, 2016-03-29 18:46:05]

lgtm

https://codereview.chromium.org/1835523002/diff/20001/cc/layers/picture_image...
File cc/layers/picture_image_layer_unittest.cc (right):

https://codereview.chromium.org/1835523002/diff/20001/cc/layers/picture_image...
cc/layers/picture_image_layer_unittest.cc:54: layer->SetLayerTreeHost(nullptr);
Do you need this? If not, then please remove.

[Khushal, 2016-03-29 18:57:53]

https://codereview.chromium.org/1835523002/diff/20001/cc/layers/picture_image...
File cc/layers/picture_image_layer_unittest.cc (right):

https://codereview.chromium.org/1835523002/diff/20001/cc/layers/picture_image...
cc/layers/picture_image_layer_unittest.cc:54: layer->SetLayerTreeHost(nullptr);
On 2016/03/29 18:46:05, vmpstr wrote:
> Do you need this? If not, then please remove. 

The Layer must be detached from its host during teardown. There is a DCHECK to
asset that in the destructor.

[Khushal, 2016-03-30 23:04:24]

friendly ping for content/ review.

[no sievers, 2016-03-30 23:39:22]

On 2016/03/30 23:04:24, Khushal wrote:
> friendly ping for content/ review.

lgtm

[Khushal, 2016-03-31 00:55:57]

The CQ bit was checked by khushalsagar@chromium.org

[commit-bot: I haz the power, 2016-03-31 00:56:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1835523002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1835523002/20001

[commit-bot: I haz the power, 2016-03-31 01:19:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 01:19:22]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Khushal, 2016-03-31 01:27:16]

The CQ bit was checked by khushalsagar@chromium.org

[commit-bot: I haz the power, 2016-03-31 01:27:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1835523002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1835523002/20001

[commit-bot: I haz the power, 2016-03-31 02:21:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 02:21:43]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Khushal, 2016-03-31 17:43:09]

The CQ bit was checked by khushalsagar@chromium.org

[commit-bot: I haz the power, 2016-03-31 17:43:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1835523002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1835523002/20001

[commit-bot: I haz the power, 2016-03-31 18:49:45]

Description was changed from

==========
cc: Add LayerTreeSetting to disable cached picture raster.

PictureImageLayer currently uses cached picture by default since it was
used by GatherPixelRefs. This is no longer necessary since we now use
GenerateDiscardableImagesMetadata in DisplayItemList to build the image
map, which supports both modes.

BUG=597163
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Add LayerTreeSetting to disable cached picture raster.

PictureImageLayer currently uses cached picture by default since it was
used by GatherPixelRefs. This is no longer necessary since we now use
GenerateDiscardableImagesMetadata in DisplayItemList to build the image
map, which supports both modes.

BUG=597163
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-03-31 18:49:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-31 18:50:58]

Description was changed from

==========
cc: Add LayerTreeSetting to disable cached picture raster.

PictureImageLayer currently uses cached picture by default since it was
used by GatherPixelRefs. This is no longer necessary since we now use
GenerateDiscardableImagesMetadata in DisplayItemList to build the image
map, which supports both modes.

BUG=597163
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Add LayerTreeSetting to disable cached picture raster.

PictureImageLayer currently uses cached picture by default since it was
used by GatherPixelRefs. This is no longer necessary since we now use
GenerateDiscardableImagesMetadata in DisplayItemList to build the image
map, which supports both modes.

BUG=597163
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/8e17a5b61e3e9a14939ebc10a152e108c2a0ba07
Cr-Commit-Position: refs/heads/master@{#384346}
==========

[commit-bot: I haz the power, 2016-03-31 18:50:59]

Patchset 2 (id:??) landed as
https://crrev.com/8e17a5b61e3e9a14939ebc10a152e108c2a0ba07
Cr-Commit-Position: refs/heads/master@{#384346}