Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 18355004: google_apis: Move data files out of chrome/test/data/chromeos (Closed)

Created:
7 years, 5 months ago by satorux1
Modified:
7 years, 5 months ago
Reviewers:
kinuko, kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, derat+watch_chromium.org, tfarina, oshima+watch_chromium.org, tzik+watch_chromium.org, nhiroki+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

google_apis: Move data files out of chrome/test/data/chromeos As these files are not Chrome OS specific. chrome/test/data/chromeos/drive -> chrome/test/data/drive chrome/test/data/chromeos/gdata -> chrome/test/data/gdata chrome/test/data/chromeos/sync_file_system -> chrome/test/data/sync_file_system chrome/test/data/chromeos/gdata/contacts is kept as is, because try bots did not work due to photo.png in the directory. Will move the directory separately. BUG=149788 TEST=none R=kinaba@chromium.org, kinuko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209618

Patch Set 1 #

Patch Set 2 : revert contacts changes #

Patch Set 3 : rebase #

Patch Set 4 : fix c/b/drive #

Patch Set 5 : fix extension tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -6940 lines) Patch
M chrome/browser/chromeos/drive/change_list_loader_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/change_list_processor_unittest.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_app_registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_file_stream_reader_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_url_request_job_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/fake_file_system_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/operation_test_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_entry_conversion_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/webkit_file_stream_reader_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/external_filesystem_apitest.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/drive/fake_drive_service_unittest.cc View 1 2 3 81 chunks +101 lines, -101 lines 0 comments Download
M chrome/browser/drive/mock_drive_service.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google_apis/base_requests_server_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/google_apis/drive_api_parser_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/google_apis/drive_api_requests_unittest.cc View 15 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_parser_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_requests_unittest.cc View 16 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/sync_file_system/drive/api_util_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service_fake_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service_sync_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/test/data/chromeos/drive/about.json View 1 chunk +0 lines, -251 lines 0 comments Download
D chrome/test/data/chromeos/drive/applist.json View 1 chunk +0 lines, -94 lines 0 comments Download
D chrome/test/data/chromeos/drive/changelist.json View 1 chunk +0 lines, -183 lines 0 comments Download
D chrome/test/data/chromeos/drive/directory_entry.json View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/test/data/chromeos/drive/file_entry.json View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/test/data/chromeos/drive/filelist.json View 1 chunk +0 lines, -146 lines 0 comments Download
D chrome/test/data/chromeos/gdata/account_metadata.json View 1 chunk +0 lines, -382 lines 0 comments Download
D chrome/test/data/chromeos/gdata/basic_feed.json View 1 chunk +0 lines, -416 lines 0 comments Download
D chrome/test/data/chromeos/gdata/deleted_hosted_document_entry.json View 1 chunk +0 lines, -105 lines 0 comments Download
D chrome/test/data/chromeos/gdata/delta_dir_moved_from_root_to_directory.json View 1 chunk +0 lines, -230 lines 0 comments Download
D chrome/test/data/chromeos/gdata/delta_file_added_in_directory.json View 1 chunk +0 lines, -249 lines 0 comments Download
D chrome/test/data/chromeos/gdata/delta_file_added_in_new_but_deleted_directory.json View 1 chunk +0 lines, -252 lines 0 comments Download
D chrome/test/data/chromeos/gdata/delta_file_added_in_new_directory.json View 1 chunk +0 lines, -249 lines 0 comments Download
D chrome/test/data/chromeos/gdata/delta_file_added_in_root.json View 1 chunk +0 lines, -163 lines 0 comments Download
D chrome/test/data/chromeos/gdata/delta_file_deleted_in_directory.json View 1 chunk +0 lines, -168 lines 0 comments Download
D chrome/test/data/chromeos/gdata/delta_file_deleted_in_root.json View 1 chunk +0 lines, -166 lines 0 comments Download
D chrome/test/data/chromeos/gdata/delta_file_moved_from_directory_to_root.json View 1 chunk +0 lines, -238 lines 0 comments Download
D chrome/test/data/chromeos/gdata/delta_file_renamed_in_directory.json View 1 chunk +0 lines, -238 lines 0 comments Download
D chrome/test/data/chromeos/gdata/directory_entry.json View 1 chunk +0 lines, -88 lines 0 comments Download
D chrome/test/data/chromeos/gdata/document_to_download.json View 1 chunk +0 lines, -99 lines 0 comments Download
D chrome/test/data/chromeos/gdata/empty_feed.json View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/test/data/chromeos/gdata/file_entry.json View 1 chunk +0 lines, -105 lines 0 comments Download
D chrome/test/data/chromeos/gdata/hosted_document_entry.json View 1 chunk +0 lines, -88 lines 0 comments Download
D chrome/test/data/chromeos/gdata/new_folder_entry.json View 1 chunk +0 lines, -89 lines 0 comments Download
D chrome/test/data/chromeos/gdata/remote_file_system_apitest_root_feed.json View 1 chunk +0 lines, -804 lines 0 comments Download
D chrome/test/data/chromeos/gdata/root_feed.json View 1 chunk +0 lines, -1354 lines 0 comments Download
D chrome/test/data/chromeos/gdata/shared_with_me_entry.json View 1 chunk +0 lines, -113 lines 0 comments Download
D chrome/test/data/chromeos/gdata/testfile.txt View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/chromeos/sync_file_system/account_metadata.json View 1 chunk +0 lines, -283 lines 0 comments Download
D chrome/test/data/chromeos/sync_file_system/initialize.json View 1 chunk +0 lines, -57 lines 0 comments Download
A + chrome/test/data/drive/about.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/drive/applist.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/drive/changelist.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/drive/directory_entry.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/drive/file_entry.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/drive/filelist.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/gdata/account_metadata.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/gdata/basic_feed.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/gdata/deleted_hosted_document_entry.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/gdata/delta_dir_moved_from_root_to_directory.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/gdata/delta_file_added_in_directory.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/gdata/delta_file_added_in_new_but_deleted_directory.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/gdata/delta_file_added_in_new_directory.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/gdata/delta_file_added_in_root.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/gdata/delta_file_deleted_in_directory.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/gdata/delta_file_deleted_in_root.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/gdata/delta_file_moved_from_directory_to_root.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/gdata/delta_file_renamed_in_directory.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/gdata/directory_entry.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/gdata/document_to_download.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/gdata/empty_feed.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/gdata/file_entry.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/gdata/hosted_document_entry.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/gdata/new_folder_entry.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/gdata/remote_file_system_apitest_root_feed.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/gdata/root_feed.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/gdata/shared_with_me_entry.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/gdata/testfile.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/sync_file_system/account_metadata.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/sync_file_system/initialize.json View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
satorux1
7 years, 5 months ago (2013-07-02 01:26:12 UTC) #1
satorux1
kinuko for c/b/sync_file_system kinaba for everything else
7 years, 5 months ago (2013-07-02 01:26:44 UTC) #2
satorux1
ugh, try bots don't work because of a .png file... Let me work around this...
7 years, 5 months ago (2013-07-02 01:30:57 UTC) #3
satorux1
reverted changes for 'contacts'
7 years, 5 months ago (2013-07-02 01:38:57 UTC) #4
kinuko
Nice, thanks for doing this long due cleanup! lgtm for c/b/sync_file_system
7 years, 5 months ago (2013-07-02 02:05:21 UTC) #5
kinaba
lgtm
7 years, 5 months ago (2013-07-02 02:12:26 UTC) #6
satorux1
7 years, 5 months ago (2013-07-02 05:12:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 manually as r209618 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698