Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1835493003: Convert XKB_KEY_XF86AudioPlay to MEDIA_PLAY_PAUSE (Closed)

Created:
4 years, 9 months ago by hychao
Modified:
4 years, 5 months ago
Reviewers:
garykac, kpschoedel
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert XKB_KEY_XF86AudioPlay to MEDIA_PLAY_PAUSE This change makes the media play/pause key on logitech keyboard to send MEDIA_PLAY_PAUSE event, so it can control the built-in media player on Chromebook. BUG=597901 TEST=test with logitech mk520r keyboard Committed: https://crrev.com/7fbc859e5011519563167b607b3f13515553e7c6 Cr-Commit-Position: refs/heads/master@{#404976}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/events/keycodes/keyboard_code_conversion_xkb.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (11 generated)
Wez
-me
4 years, 5 months ago (2016-07-08 23:34:59 UTC) #5
kpschoedel
LGTM. I think this is the appropriate mapping since the media player uses it, and ...
4 years, 5 months ago (2016-07-11 14:49:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1835493003/1
4 years, 5 months ago (2016-07-12 08:37:53 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/215928)
4 years, 5 months ago (2016-07-12 08:46:17 UTC) #10
garykac
lgtm
4 years, 5 months ago (2016-07-12 14:20:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1835493003/1
4 years, 5 months ago (2016-07-12 14:21:05 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191375)
4 years, 5 months ago (2016-07-12 17:08:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1835493003/1
4 years, 5 months ago (2016-07-13 02:36:40 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 03:44:54 UTC) #19
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 03:45:23 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 03:46:25 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7fbc859e5011519563167b607b3f13515553e7c6
Cr-Commit-Position: refs/heads/master@{#404976}

Powered by Google App Engine
This is Rietveld 408576698