|
|
Chromium Code Reviews
DescriptionConvert XKB_KEY_XF86AudioPlay to MEDIA_PLAY_PAUSE
This change makes the media play/pause key on logitech keyboard
to send MEDIA_PLAY_PAUSE event, so it can control the built-in
media player on Chromebook.
BUG=597901
TEST=test with logitech mk520r keyboard
Committed: https://crrev.com/7fbc859e5011519563167b607b3f13515553e7c6
Cr-Commit-Position: refs/heads/master@{#404976}
Patch Set 1 #
Messages
Total messages: 22 (11 generated)
Description was changed from ========== Convert XKB_KEY_XF86AudioPlay to MEDIA_PLAY_PAUSE This change makes the media play/pause key on logitech keyboard to send MEDIA_PLAY_PAUSE event, so it can control the built-in media player on Chromebook. BUG=597901 TEST=test with logitech mk520r keyboard ========== to ========== Convert XKB_KEY_XF86AudioPlay to MEDIA_PLAY_PAUSE This change makes the media play/pause key on logitech keyboard to send MEDIA_PLAY_PAUSE event, so it can control the built-in media player on Chromebook. BUG=597901 TEST=test with logitech mk520r keyboard ==========
hychao@chromium.org changed reviewers: + garykac@chromium.org, wez@chromium.org
hychao@chromium.org changed reviewers: + kpschoedel@chromium.org
wez@chromium.org changed reviewers: - wez@chromium.org
-me
LGTM. I think this is the appropriate mapping since the media player uses it, and it is consistent with the mapping to |VKEY_MEDIA_PLAY_PAUSE| in |KeyboardCodeFromXKeysym()|.
The CQ bit was checked by hychao@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by garykac@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hychao@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Convert XKB_KEY_XF86AudioPlay to MEDIA_PLAY_PAUSE This change makes the media play/pause key on logitech keyboard to send MEDIA_PLAY_PAUSE event, so it can control the built-in media player on Chromebook. BUG=597901 TEST=test with logitech mk520r keyboard ========== to ========== Convert XKB_KEY_XF86AudioPlay to MEDIA_PLAY_PAUSE This change makes the media play/pause key on logitech keyboard to send MEDIA_PLAY_PAUSE event, so it can control the built-in media player on Chromebook. BUG=597901 TEST=test with logitech mk520r keyboard ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Convert XKB_KEY_XF86AudioPlay to MEDIA_PLAY_PAUSE This change makes the media play/pause key on logitech keyboard to send MEDIA_PLAY_PAUSE event, so it can control the built-in media player on Chromebook. BUG=597901 TEST=test with logitech mk520r keyboard ========== to ========== Convert XKB_KEY_XF86AudioPlay to MEDIA_PLAY_PAUSE This change makes the media play/pause key on logitech keyboard to send MEDIA_PLAY_PAUSE event, so it can control the built-in media player on Chromebook. BUG=597901 TEST=test with logitech mk520r keyboard Committed: https://crrev.com/7fbc859e5011519563167b607b3f13515553e7c6 Cr-Commit-Position: refs/heads/master@{#404976} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7fbc859e5011519563167b607b3f13515553e7c6 Cr-Commit-Position: refs/heads/master@{#404976} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
