Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp

Issue 1835463002: Stop supporting invalid CSP directives in meta tags (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove service worker extendable event test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp
diff --git a/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp b/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp
index 5b5ceec8b60c874e87289381523e20e41ba1febc..5377f06e971bad9ebcdd6064e83fa43e1a018a01 100644
--- a/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp
+++ b/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp
@@ -5,6 +5,7 @@
#include "core/frame/csp/ContentSecurityPolicy.h"
#include "core/dom/Document.h"
+#include "core/frame/csp/CSPDirectiveList.h"
#include "core/loader/DocumentLoader.h"
#include "platform/RuntimeEnabledFeatures.h"
#include "platform/network/ContentSecurityPolicyParsers.h"
@@ -159,4 +160,41 @@ TEST_F(ContentSecurityPolicyTest, EmptyReferrerDirective)
EXPECT_EQ(ReferrerPolicyNever, document->getReferrerPolicy());
}
+// Tests that frame-ancestors directives are discarded from policies
+// delivered in <meta> elements.
+TEST_F(ContentSecurityPolicyTest, FrameAncestorsInMeta)
+{
+ csp->bindToExecutionContext(document.get());
+ csp->didReceiveHeader("frame-ancestors 'none';", ContentSecurityPolicyHeaderTypeEnforce, ContentSecurityPolicyHeaderSourceMeta);
+ EXPECT_FALSE(csp->isFrameAncestorsEnforced());
+ csp->didReceiveHeader("frame-ancestors 'none';", ContentSecurityPolicyHeaderTypeEnforce, ContentSecurityPolicyHeaderSourceHTTP);
+ EXPECT_TRUE(csp->isFrameAncestorsEnforced());
+}
+
+// Tests that sandbox directives are discarded from policies
+// delivered in <meta> elements.
+TEST_F(ContentSecurityPolicyTest, SandboxInMeta)
+{
+ csp->bindToExecutionContext(document.get());
+ csp->didReceiveHeader("sandbox;", ContentSecurityPolicyHeaderTypeEnforce, ContentSecurityPolicyHeaderSourceMeta);
+ EXPECT_FALSE(document->getSecurityOrigin()->isUnique());
+ csp->didReceiveHeader("sandbox;", ContentSecurityPolicyHeaderTypeEnforce, ContentSecurityPolicyHeaderSourceHTTP);
+ EXPECT_TRUE(document->getSecurityOrigin()->isUnique());
+}
+
+// Tests that report-uri directives are discarded from policies
+// delivered in <meta> elements.
+TEST_F(ContentSecurityPolicyTest, ReportURIInMeta)
+{
+ String policy = "img-src 'none'; report-uri http://foo.test";
+ Vector<UChar> characters;
+ policy.appendTo(characters);
+ const UChar* begin = characters.data();
+ const UChar* end = begin + characters.size();
+ RawPtr<CSPDirectiveList> directiveList(CSPDirectiveList::create(csp, begin, end, ContentSecurityPolicyHeaderTypeEnforce, ContentSecurityPolicyHeaderSourceMeta));
+ EXPECT_TRUE(directiveList->reportEndpoints().isEmpty());
+ directiveList = CSPDirectiveList::create(csp, begin, end, ContentSecurityPolicyHeaderTypeEnforce, ContentSecurityPolicyHeaderSourceHTTP);
+ EXPECT_FALSE(directiveList->reportEndpoints().isEmpty());
+}
+
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698