GN: Force use_allocator="none" in NaCl toolchains

GN: Force use_allocator="none" in NaCl toolchains

Heretofore, the use_allocator build argument has been effectively
ignored within NaCl toolchains by dint of the 'if (!is_nacl)'
around the contents of //base/allocator:allocator.  However,
configs that test the use_allocator value have not had equivalent
is_nacl exceptions.  The result is that tcmalloc is never built
in NaCl toolchains but other parts of the code think it has been.
Notably, //build/config:feature_flags fails to #define
NO_TCMALLOC.  Hence, code testing NO_TCMALLOC wrongly concludes
it can call entry points supplied by tcmalloc.  This broke the
enable_profiling=true build of some targets in the
newlib_pnacl_nonsfi toolchain, because //base/debug/profiler.cc
tries to use profiling-related tcmalloc entry points.

So this change removes that is_nacl kludge from //base/allocator
and instead wires up NaCl toolchains to force a setting of
use_allocator="none" via toolchain_args().

BUG=596918
R=dpranke@chromium.org, phosek@chromium.org

Committed: https://crrev.com/ee80d85ca30c60a5167ef6849157918bc01d757c
Cr-Commit-Position: refs/heads/master@{#383471}

[Roland McGrath, 2016-03-24 22:32:11]

The CQ bit was checked by mcgrathr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 22:32:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1835433002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1835433002/1

[Dirk Pranke, 2016-03-24 22:57:40]

lgtm

[Roland McGrath, 2016-03-24 22:59:49]

mcgrathr@chromium.org changed reviewers:
+ wfh@chromium.org

[Roland McGrath, 2016-03-24 22:59:49]

mcgrathr@chromium.org changed required reviewers:
+ wfh@chromium.org

[Roland McGrath, 2016-03-24 22:59:49]

wfh: OWNERS review for base/allocator/ please


Thanks,
Roland

[commit-bot: I haz the power, 2016-03-24 23:19:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 23:19:45]

Dry run: This issue passed the CQ dry run.

[Petr Hosek, 2016-03-25 07:08:48]

lgtm

[Will Harris, 2016-03-27 17:47:15]

On 2016/03/25 07:08:48, Petr Hosek wrote:
> lgtm

lgtm

[Will Harris, 2016-03-27 17:49:31]

The CQ bit was checked by wfh@chromium.org

[commit-bot: I haz the power, 2016-03-27 17:49:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1835433002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1835433002/1

[Will Harris, 2016-03-27 18:05:40]

The CQ bit was unchecked by wfh@chromium.org

[Will Harris, 2016-03-27 18:31:46]

I need to look at this a bit closer, need to make sure that we're not enabling
the allocator shim for NaCL - it wouldn't manifest in trybots because the shim
is currently disabled for VS2015 until
https://codereview.chromium.org/1414453017 lands.

[Will Harris, 2016-03-27 20:14:21]

lgtm again - I tested both patches together and allocator shim enabled, and it
all seems to work fine - see https://codereview.chromium.org/1837723002

[Will Harris, 2016-03-27 20:14:26]

The CQ bit was checked by wfh@chromium.org

[commit-bot: I haz the power, 2016-03-27 20:14:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1835433002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1835433002/1

[commit-bot: I haz the power, 2016-03-27 20:19:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-27 20:20:17]

Description was changed from

==========
GN: Force use_allocator="none" in NaCl toolchains

Heretofore, the use_allocator build argument has been effectively
ignored within NaCl toolchains by dint of the 'if (!is_nacl)'
around the contents of //base/allocator:allocator.  However,
configs that test the use_allocator value have not had equivalent
is_nacl exceptions.  The result is that tcmalloc is never built
in NaCl toolchains but other parts of the code think it has been.
Notably, //build/config:feature_flags fails to #define
NO_TCMALLOC.  Hence, code testing NO_TCMALLOC wrongly concludes
it can call entry points supplied by tcmalloc.  This broke the
enable_profiling=true build of some targets in the
newlib_pnacl_nonsfi toolchain, because //base/debug/profiler.cc
tries to use profiling-related tcmalloc entry points.

So this change removes that is_nacl kludge from //base/allocator
and instead wires up NaCl toolchains to force a setting of
use_allocator="none" via toolchain_args().

BUG= 596918
R=dpranke@chromium.org, phosek@chromium.org
==========

to

==========
GN: Force use_allocator="none" in NaCl toolchains

Heretofore, the use_allocator build argument has been effectively
ignored within NaCl toolchains by dint of the 'if (!is_nacl)'
around the contents of //base/allocator:allocator.  However,
configs that test the use_allocator value have not had equivalent
is_nacl exceptions.  The result is that tcmalloc is never built
in NaCl toolchains but other parts of the code think it has been.
Notably, //build/config:feature_flags fails to #define
NO_TCMALLOC.  Hence, code testing NO_TCMALLOC wrongly concludes
it can call entry points supplied by tcmalloc.  This broke the
enable_profiling=true build of some targets in the
newlib_pnacl_nonsfi toolchain, because //base/debug/profiler.cc
tries to use profiling-related tcmalloc entry points.

So this change removes that is_nacl kludge from //base/allocator
and instead wires up NaCl toolchains to force a setting of
use_allocator="none" via toolchain_args().

BUG= 596918
R=dpranke@chromium.org, phosek@chromium.org

Committed: https://crrev.com/ee80d85ca30c60a5167ef6849157918bc01d757c
Cr-Commit-Position: refs/heads/master@{#383471}
==========

[commit-bot: I haz the power, 2016-03-27 20:20:18]

Patchset 1 (id:??) landed as
https://crrev.com/ee80d85ca30c60a5167ef6849157918bc01d757c
Cr-Commit-Position: refs/heads/master@{#383471}