third_party/WebKit/Source/core/css/CSSPrimitiveValue.h - Issue 1835403003: Allow number-percentage calc() in border-image-slice

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValue.h

Issue 1835403003: Allow number-percentage calc() in border-image-slice (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: V2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/CSSCalculationValue.cpp ('K') | « third_party/WebKit/Source/core/css/CSSCalculationValue.cpp ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSPrimitiveValue.h

diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h

index 546cbdf38ca7242ebc9fc82f34a86c7c6fae95db..b0f0769aaa6f1f38d0bce514e0841be8de00cb89 100644

--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h

+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h

@@ -193,7 +193,6 @@ public:

bool isPx() const { return typeWithCalcResolved() == UnitType::Pixels; }

bool isTime() const { return type() == UnitType::Seconds || type() == UnitType::Milliseconds; }

bool isCalculated() const { return type() == UnitType::Calc; }

- bool isCalculatedPercentageWithNumber() const { return typeWithCalcResolved() == UnitType::CalcPercentageWithNumber; }

bool isCalculatedPercentageWithLength() const { return typeWithCalcResolved() == UnitType::CalcPercentageWithLength; }

static bool isResolution(UnitType type) { return type >= UnitType::DotsPerPixel && type <= UnitType::DotsPerCentimeter; }

bool isFlex() const { return typeWithCalcResolved() == UnitType::Fraction; }