third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp - Issue 1835403003: Allow number-percentage calc() in border-image-slice

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Issue 1835403003: Allow number-percentage calc() in border-image-slice (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Another approach Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

index f22d087d3a5e2aa4b325bde047ed67d1d604a5d7..7217b80a719762f66aeb9296d386f2760b86c335 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

@@ -2737,9 +2737,7 @@ static CSSValue* consumeBorderImageSlice(CSSPropertyID property, CSSParserTokenR

CSSPrimitiveValue* slices[4] = { 0 };

for (size_t index = 0; index < 4; ++index) {

- CSSPrimitiveValue* value = consumePercent(range, ValueRangeNonNegative);

- if (!value)

- value = consumeNumber(range, ValueRangeNonNegative);

+ CSSPrimitiveValue* value = consumeNumberOrPercent(range, ValueRangeNonNegative);

if (!value)

break;

slices[index] = value;