third_party/WebKit/Source/core/css/CSSCalculationValue.h - Issue 1835403003: Allow number-percentage calc() in border-image-slice

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSCalculationValue.h

Issue 1835403003: Allow number-percentage calc() in border-image-slice (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Another approach Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/css3/calc/border-image-slice-with-calc-expected.html ('k') | third_party/WebKit/Source/core/css/CSSCalculationValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSCalculationValue.h

diff --git a/third_party/WebKit/Source/core/css/CSSCalculationValue.h b/third_party/WebKit/Source/core/css/CSSCalculationValue.h

index c4957c38f3afc4941d6203a05a20e772ab83e130..2f9f06d88fcb1ada6dda78ae9f65d333bb1955fe 100644

--- a/third_party/WebKit/Source/core/css/CSSCalculationValue.h

+++ b/third_party/WebKit/Source/core/css/CSSCalculationValue.h

@@ -104,7 +104,7 @@ public:

static CSSCalcExpressionNode* createExpressionNode(CSSPrimitiveValue*, bool isInteger = false);

static CSSCalcExpressionNode* createExpressionNode(CSSCalcExpressionNode*, CSSCalcExpressionNode*, CalcOperator);

- static CSSCalcExpressionNode* createExpressionNode(double pixels, double percent);

+ static CSSCalcExpressionNode* createExpressionNode(double pixels, double percent, bool unitless = false);

PassRefPtr<CalculationValue> toCalcValue(const CSSToLengthConversionData& conversionData) const

{