mash/wm/public/interfaces/shelf_layout.mojom - Issue 1835403002: Support additional mash shelf alignments.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mash/wm/public/interfaces/shelf_layout.mojom

Issue 1835403002: Support additional mash shelf alignments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module mash.wm.mojom;

	6

	7 // These values match ash::ShelfAlignment.

	8 enum ShelfAlignment { BOTTOM, LEFT, RIGHT, };
	msw 2016/04/12 00:14:00 These enums already exist (in mash/shelf/public/in These enums already exist (in mash/shelf/public/interfaces/shelf.mojom and ash/shelf/shelf_types.h), and shelf.mojom's Shelf interface is a more feature-full version of the ShelfLayout interface below. Should I somehow share these enum and/or interface definitions? Can we do so without having the definitions live in mash/wm? (seems like they should live in mash/shelf, but mash/shelf depends on mash/wm, not the inverse). sky 2016/04/13 23:44:11 The ash directory is likely to morph into the sysu Show quoted text On 2016/04/12 00:14:00, msw wrote: > These enums already exist (in mash/shelf/public/interfaces/shelf.mojom and > ash/shelf/shelf_types.h), and shelf.mojom's Shelf interface is a more > feature-full version of the ShelfLayout interface below. Should I somehow share > these enum and/or interface definitions? Can we do so without having the > definitions live in mash/wm? (seems like they should live in mash/shelf, but > mash/shelf depends on mash/wm, not the inverse). The ash directory is likely to morph into the sysui directory. Seems like ash should pull the enums from here. I recommend moving ShelfAlignment (and others you want to sure) into a shelf_constants mojom that both places pull from. msw 2016/04/15 17:25:06 Added mash/shelf/.../shelf_constants.mojom, lmk if Show quoted text On 2016/04/13 23:44:11, sky wrote: > On 2016/04/12 00:14:00, msw wrote: > > These enums already exist (in mash/shelf/public/interfaces/shelf.mojom and > > ash/shelf/shelf_types.h), and shelf.mojom's Shelf interface is a more > > feature-full version of the ShelfLayout interface below. Should I somehow > share > > these enum and/or interface definitions? Can we do so without having the > > definitions live in mash/wm? (seems like they should live in mash/shelf, but > > mash/shelf depends on mash/wm, not the inverse). > > The ash directory is likely to morph into the sysui directory. Seems like ash > should pull the enums from here. I recommend moving ShelfAlignment (and others > you want to sure) into a shelf_constants mojom that both places pull from. Added mash/shelf/.../shelf_constants.mojom, lmk if you wanted mash/wm...
	9

	10 // These values match ash::ShelfAutoHideBehavior.

	11 enum ShelfAutoHideBehavior { ALWAYS, NEVER, HIDDEN, };

	12

	13 // Used by mojo:ash_sysui to push the current shelf state to its layout manager.

	14 interface ShelfLayout {

	15 // TODO: Update preferred sizes with alignment to avoid flicker during layout.

	16 SetAlignment(ShelfAlignment alignment);

	17 SetAutoHideBehavior(ShelfAutoHideBehavior auto_hide);

	18 };

OLD	NEW

« no previous file with comments | « mash/wm/public/interfaces/BUILD.gn ('k') | mash/wm/root_window_controller.h » ('j') | mash/wm/window_manager_application.h » ('J')