Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 183533004: add SkCanvas::NewRaster factory -- a very common use-case in chrome (Closed)

Created:
6 years, 9 months ago by reed1
Modified:
6 years, 9 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

add SkCanvas::NewRaster factory -- a very common use-case in chrome BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13617

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -15 lines) Patch
M include/core/SkCanvas.h View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
M tests/CanvasTest.cpp View 1 2 3 chunks +41 lines, -1 line 0 comments Download
M tests/DrawPathTest.cpp View 1 2 6 chunks +5 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
reed1
6 years, 9 months ago (2014-02-27 19:05:56 UTC) #1
scroggo
lgtm https://codereview.chromium.org/183533004/diff/20001/include/core/SkCanvas.h File include/core/SkCanvas.h (right): https://codereview.chromium.org/183533004/diff/20001/include/core/SkCanvas.h#newcode55 include/core/SkCanvas.h:55: * else they will be initialized to 0. ...
6 years, 9 months ago (2014-02-27 19:16:06 UTC) #2
reed1
now w/ unittest
6 years, 9 months ago (2014-02-27 19:59:33 UTC) #3
scroggo
On 2014/02/27 19:59:33, reed1 wrote: > now w/ unittest LGTM
6 years, 9 months ago (2014-02-27 20:07:43 UTC) #4
reed1
The CQ bit was checked by reed@google.com
6 years, 9 months ago (2014-02-27 20:14:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/183533004/40001
6 years, 9 months ago (2014-02-27 20:14:46 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-02-27 20:32:54 UTC) #7
Message was sent while issue was closed.
Change committed as 13617

Powered by Google App Engine
This is Rietveld 408576698