Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1835303003: We meant these to be YES... sigh. (Closed)

Created:
4 years, 8 months ago by mtklein_C
Modified:
4 years, 8 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

We meant these to be YES... sigh. This will dramatically improve link times with XCode 7.3. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1835303003 Committed: https://skia.googlesource.com/skia/+/02b2f1900db8e20daf22a2c9972311308d259426

Patch Set 1 #

Patch Set 2 : ios too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M gyp/common_conditions.gypi View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
mtklein
lgtm
4 years, 8 months ago (2016-03-28 19:29:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1835303003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1835303003/20001
4 years, 8 months ago (2016-03-28 19:29:57 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 19:43:42 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/02b2f1900db8e20daf22a2c9972311308d259426

Powered by Google App Engine
This is Rietveld 408576698