src/gpu/effects/GrDashingEffect.cpp - Issue 1835283002: Simplify GrDrawBatch uploads and token uage. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(294)

My Issues | Starred Open | Closed | All

Unified Diff: src/gpu/effects/GrDashingEffect.cpp

Issue 1835283002: Simplify GrDrawBatch uploads and token uage. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: add comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« src/gpu/batches/GrDrawBatch.h ('K') | « src/gpu/batches/GrVertexBatch.cpp ('k') | src/gpu/text/GrAtlasTextBlob_regenInBatch.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/gpu/effects/GrDashingEffect.cpp

diff --git a/src/gpu/effects/GrDashingEffect.cpp b/src/gpu/effects/GrDashingEffect.cpp

index 344c125f7ece46dbe875b77db8e16e173b9fd519..5aae3d928236de98ca4920656a19320e46f84660 100644

--- a/src/gpu/effects/GrDashingEffect.cpp

+++ b/src/gpu/effects/GrDashingEffect.cpp

@@ -358,8 +358,6 @@ private:

return;

}

- target->initDraw(gp);

-

// useAA here means Edge AA or MSAA

bool useAA = this->aaMode() != kBW_DashAAMode;

bool fullDash = this->fullDash();

@@ -627,7 +625,7 @@ private:

rectIndex++;

}

SkASSERT(0 == (curVIdx % 4) && (curVIdx / 4) == totalRectCount);

- helper.recordDraw(target);

+ helper.recordDraw(target, gp);

}

bool onCombineIfPossible(GrBatch* t, const GrCaps& caps) override {

« src/gpu/batches/GrDrawBatch.h ('K') | « src/gpu/batches/GrVertexBatch.cpp ('k') | src/gpu/text/GrAtlasTextBlob_regenInBatch.cpp » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698