src/gpu/effects/GrDashingEffect.cpp - Issue 1835283002: Simplify GrDrawBatch uploads and token uage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrDashingEffect.cpp

Issue 1835283002: Simplify GrDrawBatch uploads and token uage. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/effects/GrDashingEffect.cpp

diff --git a/src/gpu/effects/GrDashingEffect.cpp b/src/gpu/effects/GrDashingEffect.cpp

index 344b93ff853fa25ef76219f1121dcd9573124ad1..f1e8016eb9c81890f2dec4ea19e06a25301c3ae1 100644

--- a/src/gpu/effects/GrDashingEffect.cpp

+++ b/src/gpu/effects/GrDashingEffect.cpp

@@ -358,8 +358,6 @@ private:

return;

}

- target->initDraw(gp);

// useAA here means Edge AA or MSAA

bool useAA = this->aaMode() != kBW_DashAAMode;

bool fullDash = this->fullDash();

@@ -627,7 +625,7 @@ private:

rectIndex++;

}

SkASSERT(0 == (curVIdx % 4) && (curVIdx / 4) == totalRectCount);

- helper.recordDraw(target);

+ helper.recordDraw(target, gp);

}

bool onCombineIfPossible(GrBatch* t, const GrCaps& caps) override {

« no previous file with comments | « src/gpu/batches/GrVertexBatch.cpp ('k') | src/gpu/text/GrAtlasTextBlob_regenInBatch.cpp » ('j') | no next file with comments »