Add keyboard accessibility to "Get help" link text on chooser UI

Add keyboard accessibility to "Get help" link text on chooser UI

The "Get help" link text was a HyperlinkTextView before,
and pressing the Tab doesn't navigate to it. This patch
modified it using HyperlinkButtonCell so that pressing
the Tab can navigate to it.

This patch doesn't change the UI of the "Get help" link
text. It looks the same as before when using
HyperlinkTextView.

BUG=596671, 583479
Committed: https://crrev.com/4788666880388f82f62affc3499678f18b39b246
Cr-Commit-Position: refs/heads/master@{#384972}

[juncai, 2016-03-28 19:39:10]

Description was changed from

==========
added keyboard accessibility to chooser UI

BUG=596671
==========

to

==========
Add keyboard accessibility to "Get help" link text on chooser UI

The "Get help" link text was a HyperlinkTextView before, and pressing
the Tab doesn't navigate to it. This patch modified it to be a NSButton
so that pressing the Tab can set focus to it.

BUG=596671
==========

[juncai, 2016-03-28 19:41:30]

juncai@chromium.org changed reviewers:
+ rsesek@chromium.org

[juncai, 2016-03-28 19:41:30]

Please take a look.

[juncai, 2016-03-28 23:56:02]

Description was changed from

==========
Add keyboard accessibility to "Get help" link text on chooser UI

The "Get help" link text was a HyperlinkTextView before, and pressing
the Tab doesn't navigate to it. This patch modified it to be a NSButton
so that pressing the Tab can set focus to it.

BUG=596671
==========

to

==========
Add keyboard accessibility to "Get help" link text on chooser UI

The "Get help" link text was a HyperlinkTextView before, and pressing
the Tab doesn't navigate to it. This patch modified it to be a NSButton
so that pressing the Tab can set focus to it.

This patch doesn't change the UI of the "Get help" link
text. It looks the same as before when using 
HyperlinkTextView.

BUG=596671, 583479
==========

[juncai, 2016-03-28 23:57:31]

Description was changed from

==========
Add keyboard accessibility to "Get help" link text on chooser UI

The "Get help" link text was a HyperlinkTextView before, and pressing
the Tab doesn't navigate to it. This patch modified it to be a NSButton
so that pressing the Tab can set focus to it.

This patch doesn't change the UI of the "Get help" link
text. It looks the same as before when using 
HyperlinkTextView.

BUG=596671, 583479
==========

to

==========
Add keyboard accessibility to "Get help" link text on chooser UI

The "Get help" link text was a HyperlinkTextView before,
and pressing the Tab doesn't navigate to it. This patch
modified it using HyperlinkButtonCell so that pressing
the Tab can navigate to it.

This patch doesn't change the UI of the "Get help" link
text. It looks the same as before when using 
HyperlinkTextView.

BUG=596671, 583479
==========

[Robert Sesek, 2016-04-04 14:52:07]

Sorry for the delay on this. It slipped out of my inbox.

https://codereview.chromium.org/1835133002/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
(right):

https://codereview.chromium.org/1835133002/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm:492:
base::string16 linkString = base::ASCIIToUTF16("");
You don't need this conversion. The default ctor for string16 will be an empty
string.

[juncai, 2016-04-04 18:10:00]

https://codereview.chromium.org/1835133002/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
(right):

https://codereview.chromium.org/1835133002/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm:492:
base::string16 linkString = base::ASCIIToUTF16("");
On 2016/04/04 14:52:07, Robert Sesek wrote:
> You don't need this conversion. The default ctor for string16 will be an empty
> string.

Done.

[Robert Sesek, 2016-04-04 18:42:39]

lgtm

[juncai, 2016-04-04 19:10:38]

The CQ bit was checked by juncai@chromium.org

[commit-bot: I haz the power, 2016-04-04 19:11:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1835133002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1835133002/60001

[commit-bot: I haz the power, 2016-04-04 19:17:25]

Description was changed from

==========
Add keyboard accessibility to "Get help" link text on chooser UI

The "Get help" link text was a HyperlinkTextView before,
and pressing the Tab doesn't navigate to it. This patch
modified it using HyperlinkButtonCell so that pressing
the Tab can navigate to it.

This patch doesn't change the UI of the "Get help" link
text. It looks the same as before when using 
HyperlinkTextView.

BUG=596671, 583479
==========

to

==========
Add keyboard accessibility to "Get help" link text on chooser UI

The "Get help" link text was a HyperlinkTextView before,
and pressing the Tab doesn't navigate to it. This patch
modified it using HyperlinkButtonCell so that pressing
the Tab can navigate to it.

This patch doesn't change the UI of the "Get help" link
text. It looks the same as before when using 
HyperlinkTextView.

BUG=596671, 583479
==========

[commit-bot: I haz the power, 2016-04-04 19:17:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-04 19:19:46]

Description was changed from

==========
Add keyboard accessibility to "Get help" link text on chooser UI

The "Get help" link text was a HyperlinkTextView before,
and pressing the Tab doesn't navigate to it. This patch
modified it using HyperlinkButtonCell so that pressing
the Tab can navigate to it.

This patch doesn't change the UI of the "Get help" link
text. It looks the same as before when using 
HyperlinkTextView.

BUG=596671, 583479
==========

to

==========
Add keyboard accessibility to "Get help" link text on chooser UI

The "Get help" link text was a HyperlinkTextView before,
and pressing the Tab doesn't navigate to it. This patch
modified it using HyperlinkButtonCell so that pressing
the Tab can navigate to it.

This patch doesn't change the UI of the "Get help" link
text. It looks the same as before when using
HyperlinkTextView.

BUG=596671, 583479

Committed: https://crrev.com/4788666880388f82f62affc3499678f18b39b246
Cr-Commit-Position: refs/heads/master@{#384972}
==========

[commit-bot: I haz the power, 2016-04-04 19:19:47]

Patchset 4 (id:??) landed as
https://crrev.com/4788666880388f82f62affc3499678f18b39b246
Cr-Commit-Position: refs/heads/master@{#384972}