Issue 18351: Put back render view host tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18351: Put back render view host tests (Closed)

Created:
11 years, 11 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Reverting 8263. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8281

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+188 lines, -190 lines)			Patch
M	chrome/browser/render_view_host.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
A +	chrome/browser/renderer_host/test_render_view_host.h	View	2	3 chunks	+91 lines, -5 lines	0 comments	Download
A +	chrome/browser/renderer_host/test_render_view_host.cc	View		1 chunk	+70 lines, -37 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents_unittest.cc	View	2	8 chunks	+7 lines, -147 lines	0 comments	Download
M	chrome/test/unit/unittests.vcproj	View	1 2	3 chunks	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

11 years, 11 months ago (2009-01-20 03:17:22 UTC) #2

This is mostly the same as my previous patch but includes the changes to
web_contents_unittest and some additions to the test_render_view_host to make it
usable by that test.

Expand Messages | Collapse Messages