Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1835093002: Fix flaky menubar in BrowserWindowController browser test (Closed)

Created:
4 years, 9 months ago by spqchan
Modified:
4 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the flaky menubar in the BrowserWindowController browser test The menubar is flaky to test with since it may be visible/hidden when we run the test. As such, we want to ensure that it is hidden when we test the fullscreen layout. BUG=414115 Committed: https://crrev.com/b603c9dc93c7868d8d90eea8f795828f7ca80fb1 Cr-Commit-Position: refs/heads/master@{#383499}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
spqchan
PTAL
4 years, 9 months ago (2016-03-25 23:16:23 UTC) #4
Robert Sesek
LGTM
4 years, 8 months ago (2016-03-28 15:18:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1835093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1835093002/1
4 years, 8 months ago (2016-03-28 15:22:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-28 15:59:03 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 16:00:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b603c9dc93c7868d8d90eea8f795828f7ca80fb1
Cr-Commit-Position: refs/heads/master@{#383499}

Powered by Google App Engine
This is Rietveld 408576698