content/public/browser/web_contents_delegate.h - Issue 1835063002: DevTools: make app banner debug messages report with different severity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/web_contents_delegate.h

Issue 1835063002: DevTools: make app banner debug messages report with different severity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: stray include Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/banners/app_banner_debug_log.cc ('K') | « content/browser/devtools/protocol/page_handler.cc ('k') | content/public/browser/web_contents_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/web_contents_delegate.h

diff --git a/content/public/browser/web_contents_delegate.h b/content/public/browser/web_contents_delegate.h

index 2c2ac7642e8b56552f985c13e8354fb3bac9f722..074333a1af8d0e000295ab7a049504a777f397cd 100644

--- a/content/public/browser/web_contents_delegate.h

+++ b/content/public/browser/web_contents_delegate.h

@@ -531,7 +531,7 @@ class CONTENT_EXPORT WebContentsDelegate {

const std::vector<uint8_t>& proto) {}

// Requests the app banner. This method is called from the DevTools.

- virtual bool RequestAppBanner(content::WebContents* web_contents);

+ virtual void RequestAppBannerFromDevTools(content::WebContents* web_contents);

dominickn 2016/03/27 22:32:06 I think you also need to change the method in chro

pfeldman 2016/03/28 18:39:31 Done.

protected:

virtual ~WebContentsDelegate();