Re-enable CPU mipmap generation for Ganesh. Aniso mips were landed a while ago. However, the CPU bu…

Re-enable CPU mipmap generation for Ganesh. Aniso mips were landed a while ago. However, the CPU builder fails when it sees Index8 (among other things), so change the code to fallback to GPU in that case. Additionally, if we're going to be mipping an sRGB image, don't use the CPU code (which is not yet gamma correct). Unfortunately, this means that we will often be using the GPU path, still - with recent codec changes, most images are coming in tagged as sRGB.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1835003002

Committed: https://skia.googlesource.com/skia/+/b0ac1af7fab467aacbc27d20d14a09bcb960472f

Committed: https://skia.googlesource.com/skia/+/eb3429c6cdcf77ff24eaa74ab9fcf802abd160e2

[Brian Osman, 2016-03-25 18:00:13]

Description was changed from

==========
Re-enable CPU mipmap generation for Ganesh. Aniso mips were landed a while ago.
However, the CPU builder fails when it sees Index8 (among other things), so
change the code to fallback to GPU in that case. Additionally, if we're going to
be mipping an sRGB image, don't use the CPU code (which is not yet gamma
correct). Unfortunately, this means that we will often be using the GPU path,
still - with recent codec changes, most images are coming in tagged as sRGB.

BUG=skia:
==========

to

==========
Re-enable CPU mipmap generation for Ganesh. Aniso mips were landed a while ago.
However, the CPU builder fails when it sees Index8 (among other things), so
change the code to fallback to GPU in that case. Additionally, if we're going to
be mipping an sRGB image, don't use the CPU code (which is not yet gamma
correct). Unfortunately, this means that we will often be using the GPU path,
still - with recent codec changes, most images are coming in tagged as sRGB.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Brian Osman, 2016-03-25 18:02:14]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, cblume@chromium.org, reed@google.com

[Brian Osman, 2016-03-25 18:04:02]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-25 18:04:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1835003002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1835003002/1

[bsalomon, 2016-03-25 18:05:38]

On 2016/03/25 18:02:15, Brian Osman wrote:

lgtm

[cblume, 2016-03-25 18:11:21]

Dang, that was fast. :D I just got out of a tech talk and it's already done.
Thanks, Brian!

[commit-bot: I haz the power, 2016-03-25 18:20:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-25 18:20:02]

Dry run: This issue passed the CQ dry run.

[Brian Osman, 2016-03-25 18:25:26]

The CQ bit was checked by brianosman@google.com

[commit-bot: I haz the power, 2016-03-25 18:25:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1835003002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1835003002/1

[commit-bot: I haz the power, 2016-03-25 18:26:32]

Description was changed from

==========
Re-enable CPU mipmap generation for Ganesh. Aniso mips were landed a while ago.
However, the CPU builder fails when it sees Index8 (among other things), so
change the code to fallback to GPU in that case. Additionally, if we're going to
be mipping an sRGB image, don't use the CPU code (which is not yet gamma
correct). Unfortunately, this means that we will often be using the GPU path,
still - with recent codec changes, most images are coming in tagged as sRGB.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Re-enable CPU mipmap generation for Ganesh. Aniso mips were landed a while ago.
However, the CPU builder fails when it sees Index8 (among other things), so
change the code to fallback to GPU in that case. Additionally, if we're going to
be mipping an sRGB image, don't use the CPU code (which is not yet gamma
correct). Unfortunately, this means that we will often be using the GPU path,
still - with recent codec changes, most images are coming in tagged as sRGB.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/b0ac1af7fab467aacbc27d20d14a09bcb960472f
==========

[commit-bot: I haz the power, 2016-03-25 18:26:32]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b0ac1af7fab467aacbc27d20d14a09bcb960472f

[Brian Osman, 2016-03-25 18:54:12]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1836563002/ by brianosman@google.com.

The reason for reverting is: Speculative - seems likely to be the results of
nanobench crashes on several bots..

[Brian Osman, 2016-03-25 19:41:55]

Description was changed from

==========
Re-enable CPU mipmap generation for Ganesh. Aniso mips were landed a while ago.
However, the CPU builder fails when it sees Index8 (among other things), so
change the code to fallback to GPU in that case. Additionally, if we're going to
be mipping an sRGB image, don't use the CPU code (which is not yet gamma
correct). Unfortunately, this means that we will often be using the GPU path,
still - with recent codec changes, most images are coming in tagged as sRGB.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/b0ac1af7fab467aacbc27d20d14a09bcb960472f
==========

to

==========
Re-enable CPU mipmap generation for Ganesh. Aniso mips were landed a while ago.
However, the CPU builder fails when it sees Index8 (among other things), so
change the code to fallback to GPU in that case. Additionally, if we're going to
be mipping an sRGB image, don't use the CPU code (which is not yet gamma
correct). Unfortunately, this means that we will often be using the GPU path,
still - with recent codec changes, most images are coming in tagged as sRGB.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/b0ac1af7fab467aacbc27d20d14a09bcb960472f
==========

[Brian Osman, 2016-03-25 19:45:15]

Nanobench crashes were just due to returning an uninitialized texture pointer.
Oops.

[Brian Osman, 2016-03-25 19:45:23]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-03-25 19:45:23]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1835003002/#ps20001
(title: "Don't return uninitialized pointer.")

[commit-bot: I haz the power, 2016-03-25 19:45:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1835003002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1835003002/20001

[commit-bot: I haz the power, 2016-03-25 20:03:06]

Description was changed from

==========
Re-enable CPU mipmap generation for Ganesh. Aniso mips were landed a while ago.
However, the CPU builder fails when it sees Index8 (among other things), so
change the code to fallback to GPU in that case. Additionally, if we're going to
be mipping an sRGB image, don't use the CPU code (which is not yet gamma
correct). Unfortunately, this means that we will often be using the GPU path,
still - with recent codec changes, most images are coming in tagged as sRGB.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/b0ac1af7fab467aacbc27d20d14a09bcb960472f
==========

to

==========
Re-enable CPU mipmap generation for Ganesh. Aniso mips were landed a while ago.
However, the CPU builder fails when it sees Index8 (among other things), so
change the code to fallback to GPU in that case. Additionally, if we're going to
be mipping an sRGB image, don't use the CPU code (which is not yet gamma
correct). Unfortunately, this means that we will often be using the GPU path,
still - with recent codec changes, most images are coming in tagged as sRGB.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/b0ac1af7fab467aacbc27d20d14a09bcb960472f

Committed:
https://skia.googlesource.com/skia/+/eb3429c6cdcf77ff24eaa74ab9fcf802abd160e2
==========

[commit-bot: I haz the power, 2016-03-25 20:03:07]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/eb3429c6cdcf77ff24eaa74ab9fcf802abd160e2