Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: third_party/WebKit/public/platform/WebGraphicsContext3D.h

Issue 1834983003: Remove string-getting methods from WebGraphicsContext3D. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: getactive: pointers Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebGraphicsContext3D.h
diff --git a/third_party/WebKit/public/platform/WebGraphicsContext3D.h b/third_party/WebKit/public/platform/WebGraphicsContext3D.h
index 21f725bd4953d897ef5efd3e40de65582d1777b0..361aa1a5a70ff1c98ce04d9121737d703faf0fc3 100644
--- a/third_party/WebKit/public/platform/WebGraphicsContext3D.h
+++ b/third_party/WebKit/public/platform/WebGraphicsContext3D.h
@@ -74,13 +74,6 @@ typedef WGC3Duint WebGLId;
// the OpenGL ES 2.0 API.
class WebGraphicsContext3D : public WebNonCopyable {
public:
- // Return value from getActiveUniform and getActiveAttrib.
- struct ActiveInfo {
- WebString name;
- WGC3Denum type;
- WGC3Dint size;
- };
-
// Context creation attributes.
struct Attributes {
bool alpha = true;
@@ -136,19 +129,8 @@ public:
// This destructor needs to be public so that using classes can destroy instances if initialization fails.
virtual ~WebGraphicsContext3D() { }
- // The entry points below map directly to the OpenGL ES 2.0 API.
- // See: http://www.khronos.org/registry/gles/
- // and: http://www.khronos.org/opengles/sdk/docs/man/
- virtual bool getActiveAttrib(WebGLId program, WGC3Duint index, ActiveInfo&) = 0;
- virtual bool getActiveUniform(WebGLId program, WGC3Duint index, ActiveInfo&) = 0;
- virtual WebString getProgramInfoLog(WebGLId program) = 0;
- virtual WebString getShaderInfoLog(WebGLId shader) = 0;
- virtual WebString getShaderSource(WebGLId shader) = 0;
-
virtual void setErrorMessageCallback(WebGraphicsErrorMessageCallback* callback) { }
- virtual WebString getTranslatedShaderSourceANGLE(WebGLId shader) = 0;
-
// Prefer getting a GLES2Interface off WebGraphicsContext3DProvider if possible, and avoid using WebGraphicsContext3D at all.
virtual gpu::gles2::GLES2Interface* getGLES2Interface() = 0;
};

Powered by Google App Engine
This is Rietveld 408576698