third_party/WebKit/Source/modules/webgl/WebGLDebugShaders.cpp - Issue 1834983003: Remove string-getting methods from WebGraphicsContext3D.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLDebugShaders.cpp

Issue 1834983003: Remove string-getting methods from WebGraphicsContext3D. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: getactive: pointers Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webgl/GLStringQuery.h ('K') | « third_party/WebKit/Source/modules/webgl/GLStringQuery.h ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLDebugShaders.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLDebugShaders.cpp b/third_party/WebKit/Source/modules/webgl/WebGLDebugShaders.cpp

index 402713d409070045a4832abc93fab7f7fd0a2fe9..08c44b232b2b467f628d045313225566ed31ee3a 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLDebugShaders.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLDebugShaders.cpp

@@ -26,6 +26,7 @@

#include "modules/webgl/WebGLDebugShaders.h"

#include "bindings/core/v8/ExceptionState.h"

+#include "modules/webgl/GLStringQuery.h"

#include "modules/webgl/WebGLRenderingContextBase.h"

#include "modules/webgl/WebGLShader.h"

@@ -57,7 +58,8 @@ String WebGLDebugShaders::getTranslatedShaderSource(WebGLShader* shader)

return String();

if (!scoped.context()->validateWebGLObject("getTranslatedShaderSource", shader))

return "";

- return scoped.context()->ensureNotNull(scoped.context()->webContext()->getTranslatedShaderSourceANGLE(shader->object()));

+ GLStringQuery query(scoped.context()->contextGL());

+ return query.Run<GLStringQuery::TranslatedShaderSourceANGLE>(shader->object());

}

bool WebGLDebugShaders::supported(WebGLRenderingContextBase* context)