Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1834953003: got Vulkan compiling on Linux again (Closed)

Created:
4 years, 9 months ago by ethannicholas
Modified:
4 years, 9 months ago
Reviewers:
jvanverth1, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M src/gpu/vk/GrVkBackendContext.cpp View 4 chunks +20 lines, -20 lines 0 comments Download
M src/gpu/vk/GrVkExtensions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
ethannicholas
Fixes for the Linux Vulkan build failures we discussed yesterday.
4 years, 9 months ago (2016-03-25 16:45:41 UTC) #3
jvanverth1
lgtm + nit https://codereview.chromium.org/1834953003/diff/1/src/gpu/vk/GrVkGpu.cpp File src/gpu/vk/GrVkGpu.cpp (right): https://codereview.chromium.org/1834953003/diff/1/src/gpu/vk/GrVkGpu.cpp#newcode709 src/gpu/vk/GrVkGpu.cpp:709: { (uint32_t) w, (uint32_t) h, 1 ...
4 years, 9 months ago (2016-03-25 16:53:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834953003/20001
4 years, 9 months ago (2016-03-25 17:39:47 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 18:04:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/384b5e9cd36e443437de8df3b0f78ef4150efbac

Powered by Google App Engine
This is Rietveld 408576698