Update Morphology image filter to store its type

Update Morphology image filter to store its type

TBR=bsalomon@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1834953002

Committed: https://skia.googlesource.com/skia/+/40d8d62854b725b30876a01f5038c51033758f08

[robertphillips, 2016-03-25 12:53:32]

Description was changed from

==========
Update Morphology image filter to store its type
==========

to

==========
Update Morphology image filter to store its type
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-03-25 13:02:44]

Description was changed from

==========
Update Morphology image filter to store its type
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Update Morphology image filter to store its type

TBR=bsalomon@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-03-25 13:02:44]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com, senorblanco@chromium.org, senorblanco@google.com

[Stephen White, 2016-03-29 14:42:04]

https://codereview.chromium.org/1834953002/diff/20001/include/effects/SkMorph...
File include/effects/SkMorphologyImageFilter.h (right):

https://codereview.chromium.org/1834953002/diff/20001/include/effects/SkMorph...
include/effects/SkMorphologyImageFilter.h:47: const Op fOp;
Could we just provide a virtual op() function, overridden by each class? (We
already have a vtable; no need to make the object bigger.)

[robertphillips, 2016-03-29 20:27:45]

https://codereview.chromium.org/1834953002/diff/20001/include/effects/SkMorph...
File include/effects/SkMorphologyImageFilter.h (right):

https://codereview.chromium.org/1834953002/diff/20001/include/effects/SkMorph...
include/effects/SkMorphologyImageFilter.h:47: const Op fOp;
On 2016/03/29 14:42:04, Stephen White wrote:
> Could we just provide a virtual op() function, overridden by each class? (We
> already have a vtable; no need to make the object bigger.)

Done.

[Stephen White, 2016-03-30 00:28:55]

LGTM

[robertphillips, 2016-03-30 12:00:32]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 12:00:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834953002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834953002/40001

[commit-bot: I haz the power, 2016-03-30 12:11:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 12:11:20]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-03-30 15:08:49]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-03-30 15:08:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834953002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834953002/40001

[commit-bot: I haz the power, 2016-03-30 15:09:59]

Description was changed from

==========
Update Morphology image filter to store its type

TBR=bsalomon@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Update Morphology image filter to store its type

TBR=bsalomon@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/40d8d62854b725b30876a01f5038c51033758f08
==========

[commit-bot: I haz the power, 2016-03-30 15:10:00]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/40d8d62854b725b30876a01f5038c51033758f08