Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6357)

Unified Diff: chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

Issue 1834933002: Misc. cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix missing spacing Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
diff --git a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
index 9cefe0feae97a9b6b38aafbb199fc0b842ef78e0..ccf44490d3f7724605dd310449134ec4d614b3b1 100644
--- a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
+++ b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
@@ -93,18 +93,22 @@ class IconLabelBubbleView : public views::InkDropHostView {
gfx::Size GetSizeForLabelWidth(int label_width) const;
- // Amount of padding from the edge of the icon / label to the outer edge of
- // the bubble view. If |leading| is true, this is the padding at the
- // beginning of the bubble (left in LTR), otherwise it's the trailing padding.
- int GetBubbleOuterPadding(bool leading) const;
+ // Returns the minimum width the view can be to show the complete image when
+ // the background is showing.
+ int MinimumWidthForImageWithBackgroundShown() const;
private:
// Sets a background color on |label_| based on |chip_background_color| and
// the parent's bg color.
void SetLabelBackgroundColor(SkColor chip_background_color);
- // As above, but for Material Design. TODO(estade): remove/replace the above.
- int GetBubbleOuterPaddingMd(bool leading) const;
+ // Amount of padding from the leading edge of the view to the leading edge of
+ // the image (if |leading| is true), or from the trailing edge of the label
+ // (or image, if the label is invisible) to the trailing edge of the view.
+ int GetOuterPadding(bool leading) const;
+
+ // Spacing between the image and the label.
+ int GetInternalSpacing() const;
// views::View:
const char* GetClassName() const override;

Powered by Google App Engine
This is Rietveld 408576698