Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 1834913002: Fix visual viewport for OOPIF. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix webview and unit tests Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
index 4f24ed063bc42c869615d57ad344522df082ad49..8e58307f7bafde8aa7b6b1577350af8b1e968448 100644
--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
@@ -35,6 +35,7 @@
#include "core/editing/FrameSelection.h"
#include "core/editing/InputMethodController.h"
#include "core/editing/PlainTextRange.h"
+#include "core/frame/FrameHost.h"
#include "core/frame/FrameView.h"
#include "core/frame/RemoteFrame.h"
#include "core/frame/Settings.h"
@@ -199,7 +200,8 @@ void WebFrameWidgetImpl::sendResizeEventAndRepaint()
void WebFrameWidgetImpl::resizeVisualViewport(const WebSize& newSize)
{
- // FIXME: Implement visual viewport for out-of-process iframes.
+ page()->frameHost().visualViewport().setSize(newSize);
+ page()->frameHost().visualViewport().clampToBoundaries();
alexmos 2016/03/26 00:00:48 Note that I didn't have to add any plumbing for se
kenrb 2016/03/31 17:41:58 Eventually we might want to change some of the res
alexmos 2016/03/31 23:03:47 Good point. I suppose this means that in cases li
}
void WebFrameWidgetImpl::updateMainFrameLayoutSize()

Powered by Google App Engine
This is Rietveld 408576698