Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1834893002: Treat empty string DartPackage as no DartPackage specified (Closed)

Created:
4 years, 9 months ago by Cutch
Modified:
4 years, 8 months ago
Reviewers:
zra
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Treat empty string DartPackage as no DartPackage specified BUG= R=zra@google.com Committed: https://chromium.googlesource.com/external/mojo/+/d3a630fd6b85c5fdbb944d748827e79e962eb012

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M mojo/dart/tools/presubmit/check_mojom_dart.py View 1 chunk +7 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/mojom_dart_generator.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Cutch
4 years, 8 months ago (2016-03-28 16:37:45 UTC) #1
Cutch
4 years, 8 months ago (2016-03-28 20:12:14 UTC) #4
Cutch
4 years, 8 months ago (2016-03-28 20:12:15 UTC) #5
zra
lgtm
4 years, 8 months ago (2016-03-28 20:14:27 UTC) #6
Cutch
4 years, 8 months ago (2016-03-28 21:41:18 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d3a630fd6b85c5fdbb944d748827e79e962eb012 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698